Update examples to optionally use the official execution scripts #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.4.2 to 7.4.3. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.4.2...7.4.3) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
saimanikant
force-pushed
the
mguntupa/exec_script
branch
3 times, most recently
from
0831568 to
3718c3a
Compare
github-actions
bot
added
the
documentation
saimanikant
force-pushed
the
mguntupa/exec_script
branch
from
3718c3a to
7e27754
Compare
| num_cores=6, | ||
| memory=6000 * 1024 * 1024, | ||
| disk_space=4000 * 1024 * 1024, | ||
| distributed=True, |
Contributor
There was a problem hiding this comment.
please set distributed=USE_LSDYNA_MPP
| memory=6000 * 1024 * 1024, | ||
| disk_space=4000 * 1024 * 1024, | ||
| distributed=True, | ||
| platform="Windows", |
Contributor
There was a problem hiding this comment.
it's the second task that need to run on Windows, not the solver run
| num_cores=2, | ||
| memory=3000, | ||
| disk_space=4000, | ||
| distributed=True, |
Contributor
There was a problem hiding this comment.
this should have distributed=False, it's just a GUI post-processor, can't run over multiple nodes!
Contributor
There was a problem hiding this comment.
The purpose of this test_examples is to at least make sure we're able to create the example projects, without necessarily solve them. In this spirit, we should also make sure we can create the exec_script variant of at least some of the examples.
FedericoNegri
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
#233
Checklist
Please complete the following checklist before submitting your pull request: