Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to feature #16537

Merged
merged 29 commits into from May 12, 2019
Merged

Merge master to feature #16537

merged 29 commits into from May 12, 2019

Conversation

afc163 and others added 29 commits May 8, 2019 16:00
fix: 🐛 Fix Select selected and disabled item wrong hover color
* updated after resolving conflicts

* lint error fixes
fix: Print reject error when ActionButton catch promise rejects
fix(PageHeader): Should not render blank dom
add missing params in Menu's onClick, onSelect and onDeselect callback
* fix: codesandbox not support lodash/*

* fix: remove slash deps
* fix[Select]: add missing type definition

* update docs
Change `getFieldError` and `getFieldsError` to return actual types, instead of very restrictive `Object` type (which should be avoided in general, in favour of `unknown`, `object`, or `Record` depending on actual use).
fix(forms): improve field error method type defs
Just a spelling update (fix) for the CSS doc styl to style
@request-info
Copy link

request-info bot commented May 12, 2019

We would appreciate it if you could provide us with more info about this issue/pr! Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro or a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 7 days.

@buildsize
Copy link

buildsize bot commented May 12, 2019

File name Previous Size New Size Change
package-lock.json 820.11 KB 821.33 KB 1.21 KB (0%)

@yutingzhao1991 yutingzhao1991 changed the base branch from master to feature May 12, 2019 14:39
@netlify
Copy link

netlify bot commented May 12, 2019

Deploy preview for ant-design ready!

Built with commit adfc435

https://deploy-preview-16537--ant-design.netlify.com

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #16537 into feature will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #16537      +/-   ##
===========================================
+ Coverage    95.65%   95.71%   +0.06%     
===========================================
  Files          258      258              
  Lines         7107     7120      +13     
  Branches      1968     1970       +2     
===========================================
+ Hits          6798     6815      +17     
+ Misses         307      303       -4     
  Partials         2        2
Impacted Files Coverage Δ
components/select/index.tsx 96.87% <ø> (ø) ⬆️
components/list/index.tsx 97.77% <ø> (ø) ⬆️
components/form/Form.tsx 91.3% <ø> (ø) ⬆️
components/transfer/list.tsx 94.33% <100%> (+0.52%) ⬆️
components/modal/ActionButton.tsx 90% <100%> (+14.13%) ⬆️
components/upload/Upload.tsx 95.12% <100%> (ø) ⬆️
components/page-header/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88589d...adfc435. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet