Skip to content

Comments

Add GCP Service Account rule#11774

Merged
ashb merged 12 commits intoapache:v1-10-stablefrom
PolideaInternal:u12
Oct 23, 2020
Merged

Add GCP Service Account rule#11774
ashb merged 12 commits intoapache:v1-10-stablefrom
PolideaInternal:u12

Conversation

@turbaszek
Copy link
Member


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

mik-laj and others added 12 commits October 23, 2020 09:43
Co-authored-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
(cherry picked from commit 2904810)
The rules were auto-registered using metaclass but first
we would need to load modules that include the classes.
So it's simpler to just load all rule classes and avoid
metaclass.

(cherry picked from commit 1df5d4d)
Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>
(cherry picked from commit 6b66bb1)
Instead of displaying plain text we can use pygments formatter and lexer
to improve readability and UX of airflow upgrade_check command.

(cherry picked from commit 7d83661)
apache#11090)

* Add rules to ensure users are using pod_template_file for KubernetesExecutor

* add invalid configs check

* fix static checks

* fix syntax

* remove unecessary files

Co-authored-by: Daniel Imberman <daniel@astronomer.io>
(cherry picked from commit 128c445)
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@ashb ashb merged commit 6b14f74 into apache:v1-10-stable Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants