Skip to content

default_args type check#21780

Closed
rustikk wants to merge 21 commits intoapache:mainfrom
rustikk:default-args-type-check
Closed

default_args type check#21780
rustikk wants to merge 21 commits intoapache:mainfrom
rustikk:default-args-type-check

Conversation

@rustikk
Copy link
Copy Markdown
Contributor

@rustikk rustikk commented Feb 24, 2022

closes: #21768

When the default_args is anything but a dictionary or None a not so helpful error shows. This commit adds a TypeError if anything other than a dictionary or None is passed to default_args at either the dag level, the taskgroup level or the task level and returns a TypeError saying "default_args must be a dictionary".

@rustikk rustikk changed the title Default args type check default_args type check Feb 24, 2022
rustikk and others added 16 commits February 23, 2022 20:32
…val is high (apache#21413)

The finished dagrun was still being seen as running when we call dag.get_num_active_runs
because the session was not flushed. This PR fixes it
Building image for now shoudl be forced to linux/amd64 as this is
the only supported platform. When using BUILDKIT, the default
platform depends on the OS/processor, but until we implement
multi-platform images we force them to linux/amd64.

Setting it as parameter of docker build instead of env variables
is more explicit and allows to copy&paste the whole command
to reproduce it outside of breeze when verbose is used
independently if you are on Linux, MacOS Intel/ARM.
Co-authored-by: Tzu-ping Chung <tp@astronomer.io>
There is a new rule in markdownlint which has been violated in
main when new version of pre-commits is installed introduced in
the apache#21734
Make task instance rendered template fields available in the REST API.

Co-authored-by: Mocheng Guo <mocheng.guo@airbnb.com>
…#21793)

Some of the subcommands here don't actually need a full dag, so there is
no point paying the (possibly long) time to parse a dagfile if we could
go directly to the DB instead.

Closes apache#21450
@rustikk
Copy link
Copy Markdown
Contributor Author

rustikk commented Feb 25, 2022

I did the rebase wrong so I'm closing this and making a new PR.

@rustikk rustikk closed this Feb 25, 2022
@rustikk rustikk deleted the default-args-type-check branch February 25, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

raise TypeError when default_args not a dictionary