[AIRFLOW-2211] Rename hdfs_sensors.py to hdfs_sensor.py for consistency#3127
[AIRFLOW-2211] Rename hdfs_sensors.py to hdfs_sensor.py for consistency#3127feng-tao wants to merge 1 commit into
Conversation
|
@feng-tao Can you take a look at the flake8 violations? Cheers |
|
thanks @Fokko . Will check today :) |
Codecov Report
@@ Coverage Diff @@
## master #3127 +/- ##
==========================================
- Coverage 73.1% 73.09% -0.01%
==========================================
Files 180 180
Lines 12648 12648
==========================================
- Hits 9246 9245 -1
- Misses 3402 3403 +1
Continue to review full report at Codecov.
|
|
hey @Fokko , I fix the flake8 error :). Would you mind taking a look? |
|
@feng-tao Good point, but this isn't necessary. Splitting the sensors files has been done after 1.8.2 and no release has been done since then, so this will only affect people which are building from master, but I guess they might expect some breaking changes now and then ;) |
|
@Fokko Sorry if I misunderstand, but airflow/contrib/sensors/hdfs_sensors.py seems to have been shipped with 1.8.0. So I thought this change is backward incompatible since its users from 1.8.0+ have to rewrite import statements in their code. Is this right? |
|
@sekikn Oops, I missed that. In that case this should be mentioned in the UPDATING.md. |
Closes apache#3127 from feng-tao/airflow-2211
Make sure you have checked all steps below.
JIRA
Description
Rename hdfs_sensors.py to hdfs_sensor.py for consistency.
Tests
no. The change is trivial.
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diff