Skip to content

[AIRFLOW-2211] Rename hdfs_sensors.py to hdfs_sensor.py for consistency#3127

Closed
feng-tao wants to merge 1 commit into
apache:masterfrom
feng-tao:airflow-2211
Closed

[AIRFLOW-2211] Rename hdfs_sensors.py to hdfs_sensor.py for consistency#3127
feng-tao wants to merge 1 commit into
apache:masterfrom
feng-tao:airflow-2211

Conversation

@feng-tao

Copy link
Copy Markdown
Member

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Rename hdfs_sensors.py to hdfs_sensor.py for consistency.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    no. The change is trivial.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@Fokko

Fokko commented Mar 14, 2018

Copy link
Copy Markdown
Contributor

@feng-tao Can you take a look at the flake8 violations? Cheers

@feng-tao

Copy link
Copy Markdown
Member Author

thanks @Fokko . Will check today :)

@codecov-io

codecov-io commented Mar 15, 2018

Copy link
Copy Markdown

Codecov Report

Merging #3127 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3127      +/-   ##
==========================================
- Coverage    73.1%   73.09%   -0.01%     
==========================================
  Files         180      180              
  Lines       12648    12648              
==========================================
- Hits         9246     9245       -1     
- Misses       3402     3403       +1
Impacted Files Coverage Δ
airflow/models.py 87.28% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a880a7...5def129. Read the comment docs.

@feng-tao

Copy link
Copy Markdown
Member Author

hey @Fokko , I fix the flake8 error :). Would you mind taking a look?

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feng-tao Thanks for pinging me. Merging right away. Cheers

@asfgit asfgit closed this in e83b015 Mar 19, 2018
@sekikn

sekikn commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@feng-tao @Fokko This is incompatible change, so should we add an entry to UPDATING.md just like #3141?

@Fokko

Fokko commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@feng-tao Good point, but this isn't necessary. Splitting the sensors files has been done after 1.8.2 and no release has been done since then, so this will only affect people which are building from master, but I guess they might expect some breaking changes now and then ;)

@sekikn

sekikn commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

@Fokko Sorry if I misunderstand, but airflow/contrib/sensors/hdfs_sensors.py seems to have been shipped with 1.8.0. So I thought this change is backward incompatible since its users from 1.8.0+ have to rewrite import statements in their code. Is this right?

@Fokko

Fokko commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

@sekikn Oops, I missed that. In that case this should be mentioned in the UPDATING.md.

@feng-tao

Copy link
Copy Markdown
Member Author

@Fokko and @sekikn , let me submit a pr today to add that info in the doc. Thanks for pointing out.

@sekikn

sekikn commented Mar 21, 2018

Copy link
Copy Markdown
Contributor

@feng-tao @Fokko Thanks! :)

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants