[AIRFLOW-2226] Rename google_cloud_storage_default to google_cloud_default#3141
Closed
Fokko wants to merge 1 commit into
Closed
[AIRFLOW-2226] Rename google_cloud_storage_default to google_cloud_default#3141Fokko wants to merge 1 commit into
Fokko wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3141 +/- ##
==========================================
- Coverage 73.06% 73.05% -0.01%
==========================================
Files 180 180
Lines 12654 12654
==========================================
- Hits 9246 9245 -1
- Misses 3408 3409 +1
Continue to review full report at Codecov.
|
Contributor
|
LGTM, this is technical bw-incompatible. Should add an entry to UPDATING.md |
Contributor
|
+1 |
…fault The Google cloud operators uses both google_cloud_storage_default and google_cloud_default as a default conn_id. This is confusing and the google_cloud_storage_default conn_id isnt initialized by default in db.py Therefore we rename the google_cloud_storage_default to google_cloud_default for simplicity and convenience
Contributor
Author
|
Thanks @criccomini, I've added a section to the UPDATING.md |
5 tasks
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
…fault The Google cloud operators uses both google_cloud_storage_default and google_cloud_default as a default conn_id. This is confusing and the google_cloud_storage_default conn_id isnt initialized by default in db.py Therefore we rename the google_cloud_storage_default to google_cloud_default for simplicity and convenience Closes apache#3141 from Fokko/airflow-2226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Google cloud operators uses both google_cloud_storage_default and google_cloud_default as a default conn_id. This is confusing and the google_cloud_storage_default conn_id isnt initialized by default in db.py. Therefore we rename the google_cloud_storage_default to google_cloud_default for simplicity and convenience.
Make sure you have checked all steps below.
JIRA
Description
Tests
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diff