Skip to content

Add dag_id in deprecation warnings in dag.py#42598

Closed
r-richmond wants to merge 66 commits intoapache:v2-10-testfrom
r-richmond:patch-1
Closed

Add dag_id in deprecation warnings in dag.py#42598
r-richmond wants to merge 66 commits intoapache:v2-10-testfrom
r-richmond:patch-1

Conversation

@r-richmond
Copy link
Contributor

What this does

  1. It adds the dag_id in the warnings when a removedInAirflow3Warning is warned.

Why

  1. It makes it much easier to find the dogs impacted by these conditions when their id is included in the warning.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

potiuk and others added 30 commits August 20, 2024 21:22
)

The PROD image building fails currently in non-main because it
attempts to build source provider packages rather than use them from
PyPi when PR is run against "v-test" branch.

This PR fixes it:

* PROD images in non-main-targetted build will pull providers from
  PyPI rather than build them
* they use PyPI constraints to install the providers
* they use UV - which should speed up building of the images

(cherry picked from commit 4d5f1c4)
(cherry picked from commit bf0d412)
…41610)

* Enable pull requests to be run from v*test branches (#41474) (#41476)

Since we switch from direct push of cherry-picking to open PRs
against v*test branch, we should enable PRs to run for the target
branch.

(cherry picked from commit a9363e6)

* Prevent provider lowest-dependency tests to run in non-main branch (#41478) (#41481)

When running tests in v2-10-test branch, lowest depenency tests
are run for providers - because when calculating separate tests,
the "skip_provider_tests" has not been used to filter them out.

This PR fixes it.

(cherry picked from commit 75da507)

* Make PROD image building works in non-main PRs (#41480) (#41484)

The PROD image building fails currently in non-main because it
attempts to build source provider packages rather than use them from
PyPi when PR is run against "v-test" branch.

This PR fixes it:

* PROD images in non-main-targetted build will pull providers from
  PyPI rather than build them
* they use PyPI constraints to install the providers
* they use UV - which should speed up building of the images

(cherry picked from commit 4d5f1c4)

* Add WebEncoder for trigger page rendering to avoid render failure (#41350) (#41485)

Co-authored-by: M. Olcay Tercanlı <muhammed_tercanli@epam.com>

* Incorrect try number subtraction producing invalid span id for OTEL airflow (issue #41501) (#41502) (#41535)

* Fix for issue #39336

* removed unnecessary import

(cherry picked from commit dd3c3a7)

Co-authored-by: Howard Yoo <32691630+howardyoo@users.noreply.github.com>

* Fix failing pydantic v1 tests (#41534) (#41541)

We need to exclude some versions of Pydantic v1 because it conflicts
with aws provider.

(cherry picked from commit a033c5f)

* Fix Non-DB test calculation for main builds (#41499) (#41543)

Pytest has a weird behaviour that it will not collect tests
from parent folder when subfolder of it is specified after the
parent folder. This caused some non-db tests from providers folder
have been skipped during main build.

The issue in Pytest 8.2 (used to work before) is tracked at
pytest-dev/pytest#12605

(cherry picked from commit d489826)

* Add changelog for airflow python client 2.10.0 (#41583) (#41584)

* Add changelog for airflow python client 2.10.0

* Update client version

(cherry picked from commit 317a28e)

* Make all test pass in Database Isolation mode (#41567)

This adds dedicated "DatabaseIsolation" test to airflow v2-10-test
branch..

The DatabaseIsolation test will run all "db-tests" with enabled
DB isolation mode and running `internal-api` component - groups
of tests marked with "skip-if-database-isolation" will be skipped.

* Upgrade build and chart dependencies (#41570) (#41588)

(cherry picked from commit c88192c)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

* Limit watchtower as depenendcy as 3.3.0 breaks moin. (#41612)

(cherry picked from commit 1b602d5)

* Enable running Pull Requests against v2-10-stable branch (#41624)

(cherry picked from commit e306e7f)

* Fix tests/models/test_variable.py for database isolation mode (#41414)

* Fix tests/models/test_variable.py for database isolation mode

* Review feedback

(cherry picked from commit 736ebfe)

* Make latest botocore tests green (#41626)

The latest botocore tests are conflicting with a few requirements
and until apache-beam upcoming version is released we need to do
some manual exclusions. Those exclusions should make latest botocore
test green again.

(cherry picked from commit a13ccbb)

* Simpler task retrieval for taskinstance test (#41389)

The test has been updated for DB isolation but the retrieval of
task was not intuitive and it could lead to flaky tests possibly

(cherry picked from commit f25adf1)

* Skip  database isolation case for task mapping taskinstance tests (#41471)

Related: #41067
(cherry picked from commit 7718bd7)

* Skipping tests for db isolation because similar tests were skipped (#41450)

(cherry picked from commit e94b508)

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Co-authored-by: M. Olcay Tercanlı <muhammed_tercanli@epam.com>
Co-authored-by: Howard Yoo <32691630+howardyoo@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
* able to change the 'Changed Row' display message after edit

* added message in connection form to warn of empty fields

* attempt to warn the specific fields cannot be empty

* revert change because need to check fields before save is clicked

* issues warning for specific fields that can't be deleted after save

* removed the individual warnings

* changed status to concise string

* added more concise suggestion



---------

Co-authored-by: Lucy Hu <90779522+lh5844@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: phi-friday <phi.friday@gmail.com>
Co-authored-by: Computer Network Investigation <121175071+JSCU-CNI@users.noreply.github.com>
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Co-authored-by: obarisk <obarisk@yiyixiu.idv.tw>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
* Adding rel property to hyperlinks in logs

* fixing tests

(cherry picked from commit 79db243)
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit e02052b)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(docs): add an example for auth with keycloak

Added a new section in the authentication documentation that provides a code of configuring Airflow to work with Keycloak.

* chore(docs): add an example for auth with keycloak

Fix spelling and styling

* chore(docs): add an example for auth with keycloak

Fix static checks

Co-authored-by: Natsu <34879762+hoalongnatsu@users.noreply.github.com>
)

(cherry picked from commit 83ba17f)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Never fail an ltj over a heartbeat

* Log a warning on failed heartbeat

* Avoid using f-string in log

* Remove unnecessary pass statement

(cherry picked from commit 6647610)

Co-authored-by: Collin McNulty <collin.mcnulty@gmail.com>
…1809)

* Fix: Keep compatibility with old FAB versions (#41549)

* Fix: Tests after #41549 (Keep compatibility with old FAB versions)

* Fix test_dag and test_dagbag
…rrors (#41715) (#41820)

(cherry picked from commit 1c53961)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
…41829)

* Fix: DAGs are not marked as stale if the AIRFLOW__CORE__DAGS_FOLDER changes

* Update airflow/dag_processing/manager.py

* Add testcase

* Add code comment

* Update code comment

* Update the logic for checking the current dag_directory

* Update testcases

* Remove unwanted code

* Uncomment code

* Add processor_subdir when creating processor_subdir

* Fix test_retry_still_in_executor test

* Remove config from test

* Update airflow/dag_processing/manager.py

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

* Update if condition for readability

---------

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
(cherry picked from commit 9f30a41)
…r as True. (#41834)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
* logout link in no roles error page fix

* review comments

(cherry picked from commit 032ac87)

Co-authored-by: Gagan Bhullar <g.deepsingh1@gmail.com>
…1874)

Earlier PR create to address the issue was not handling the case for the Example Dags, due to which the example dags were marked as stale since they are not present in the dag_directory. This PR handles that scenarios and update the testcase accordingly.

related: #41432
(cherry picked from commit 435e968)
Bumps [webpack](https://github.com/webpack/webpack) from 5.76.0 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.76.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit e8888fe)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#41890)

(cherry picked from commit 87a4a51)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
…#41893) (#41895)

Since the similar test(test_scan_stale_dags_standalone_mode) are skipped in DB isolation mode

(cherry picked from commit 07af14a)
* Update release command for Airflow 2

For airflow 2, we create a branch out of v2-10-test and sync that branch
with v2-10-stable to make a release.

* Update CI check
jscheffl and others added 11 commits September 13, 2024 11:15
…42208)

* Add extra, conf and renderedTemplates as keys to skip camelCasing

* remove conf, check for extra in lists

(cherry picked from commit c29f8dd)

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
) (#42213)

fix: only treat null, undefined or NaN as NULL in XComEntry render

fix: use coalescing nullish check + isNaN

fix: only treat null/undefined as falsy when rendering XComEntry
(cherry picked from commit ade9de1)

Co-authored-by: Detlev V. <detvdael.services@protonmail.com>
* Add 'lower' to require_confirmation_dag_change

* Set input attribute only if require-confirmation is true

(cherry picked from commit 9a1f9e9)

Co-authored-by: Nikita <sowow359@ya.ru>
…(41433) (#41829) (#41893) 41829 (#42220)

* Revert "Skip test_scan_stale_dags_when_dag_folder_change in DB isolation mode (#41893)"

This reverts commit 07af14a.

* Revert "Fix: DAGs are not marked as stale if the dags folder change (#41433) (#41829)"

This reverts commit 996af78.
* update requires

* update requires

(cherry picked from commit 44eba06)
)

(cherry picked from commit a5d0a63)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.