Add validate trigger events deferrable tasks OpenAI provider#69506
Open
takayoshi-makabe wants to merge 1 commit into
Open
Add validate trigger events deferrable tasks OpenAI provider#69506takayoshi-makabe wants to merge 1 commit into
takayoshi-makabe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAITriggerBatchOperator.execute_completeused the trigger event without validating it, branching deny-list style (onlystatus == "error"raised, everything else succeeded):cancelledwas marked SUCCESS: the provider's ownOpenAIBatchTriggeremits{"status": "cancelled"}when the batch is cancelled while the task is deferred, but onlyerrorraised — so the task went green with no results. The non-deferrable path (OpenAIHook.wait_for_batch) has raised forCANCELLED/CANCELLINGsince feat(providers/openai): support batch api in hook/operator/trigger #41554, so the two modes of the same operator disagreed.event=None: crashed with an opaqueTypeError: 'NoneType' object is not subscriptable.status(triggerer/worker version skew, custom trigger): fell through into the success path.Same fix shape as the anthropic provider in #69379: a validate_execute_complete_event() helper plus allow-list branching (status != "success" raises).
Also fixes a missing
elseinOpenAIBatchTrigger.run()that yielded a second, spuriouserrorevent after every terminal event (benign — only the first event is consumed — but incorrect).Was generative AI tooling used to co-author this PR?
Claude Code
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.