[v3-3-test] Bump eslint-plugin-unicorn to 72.0.0 - #70520
Merged
Merged
Conversation
Adapted from apache#70402 (which bumped 71.1.0 to 72.0.0 on main); v3-3-test was on ^64.0.0, so this is a larger jump. Includes the lint fixes the newer unicorn rules surface.
shahar1
marked this pull request as ready for review
July 27, 2026 12:50
shahar1
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 27, 2026 12:50
Member
Author
|
Tested locally and working as expected |
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport-ish of #70402 to
v3-3-test.Not a clean cherry-pick: #70402 bumped
eslint-plugin-unicorn71.1.0 → 72.0.0 onmain, butv3-3-testwas pinned at^64.0.0, so this is a larger jump. Rather than hand-merge the divergedpnpm-lock.yaml, the lock was regenerated for just this dependency (pnpm install).The newer unicorn rules surface some findings, fixed here:
eslint --fixauto-resolved the fixable ones (numeric separators, etc.).prefer-ternary(source:usePluginTabs,TaskInstance).consistent-function-scopingon test-local helper components (MarkdownModal.test,CreateAssetEventModal.test) — kept in place with a documentedeslint-disable(one must stay inside avi.mockfactory due to vitest hoisting).eslint --quiet(CI mode) passes with 0 errors.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines