[v3-3-test] Bump eslint-plugin-unicorn to 72.0.0

airflow-core/src/airflow/ui/package.json

@@ -103,7 +103,7 @@
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^7.1.1",
     "eslint-plugin-react-refresh": "^0.5.3",
-    "eslint-plugin-unicorn": "^64.0.0",
+    "eslint-plugin-unicorn": "^72.0.0",
     "globals": "^15.15.0",
     "happy-dom": "^20.10.6",
     "jsonc-eslint-parser": "^2.4.2",

airflow-core/src/airflow/ui/src/components/AnsiRenderer.tsx

@@ -131,7 +131,7 @@ const createChakraProps = (bundle: AnserJsonEntry) => {
     case "underline":
       props.textDecoration = "underline";
       break;
-    // eslint-disable-next-line unicorn/no-useless-switch-case
+
     case null:
     default:
       break;

airflow-core/src/airflow/ui/src/components/MarkdownModal.test.tsx

@@ -96,6 +96,7 @@ describe("MarkdownModal", () => {
 
   it("toggles between the textarea and a rendered preview while editing", () => {
     // The modal is controlled, so drive mdContent from a stateful wrapper.
+    // eslint-disable-next-line unicorn/consistent-function-scoping -- test-local wrapper, keep beside the test
     const ControlledModal = () => {
       const [value, setValue] = useState("");
 

airflow-core/src/airflow/ui/src/hooks/usePluginTabs.tsx

@@ -44,11 +44,10 @@ export const usePluginTabs = (destination: string): Array<TabPlugin> => {
 
   return externalViews.map((view) => {
     // Choose icon based on theme - prefer dark mode icon if available and in dark mode
-    let iconSrc = view.icon;
-
-    if (colorMode === "dark" && view.icon_dark_mode !== undefined && view.icon_dark_mode !== null) {
-      iconSrc = view.icon_dark_mode;
-    }
+    const iconSrc =
+      colorMode === "dark" && view.icon_dark_mode !== undefined && view.icon_dark_mode !== null
+        ? view.icon_dark_mode
+        : view.icon;
 
     const icon =
       iconSrc !== undefined && iconSrc !== null ? (

airflow-core/src/airflow/ui/src/mocks/handlers/log.ts

@@ -30,7 +30,7 @@ const ti = {
     id: "019518f4-1adb-7223-a917-45fe08b78947",
     version_number: 1,
   },
-  duration: 0.203_977,
+  duration: 0.203977,
   end_date: "2025-02-18T12:19:56.467235Z",
   executor: null,
   executor_config: "{}",

airflow-core/src/airflow/ui/src/pages/Asset/CreateAssetEventModal.test.tsx

@@ -45,6 +45,7 @@ vi.mock("src/components/ui", async (importOriginal) => {
   // Must stay inside the factory: vitest hoists vi.mock above module scope, so an outer-scope
   // component cannot be referenced here.
 
+  // eslint-disable-next-line unicorn/consistent-function-scoping -- must stay in the vi.mock factory (hoisting)
   const DialogPart = ({ children }: { readonly children?: ReactNode }) => <div>{children}</div>;
 
   return {

airflow-core/src/airflow/ui/src/pages/TaskInstance/RenderedTemplates.tsx

@@ -47,7 +47,7 @@ const RenderedTemplatesContent = () => {
             if (value !== null && value !== undefined) {
               const renderedValue =
                 typeof value === "string"
-                  ? value.split("\\n").join("\n").replaceAll(/\\$/gmu, "")
+                  ? value.replaceAll("\\n", "\n").replaceAll(/\\$/gmu, "")
                   : JSON.stringify(value, null, 2);
               const language = detectLanguage(renderedValue);
 

airflow-core/src/airflow/ui/src/pages/TaskInstance/TaskInstance.tsx

@@ -92,21 +92,20 @@ export const TaskInstance = () => {
   const taskCount = Object.entries(taskInstanceSummary?.child_states ?? {})
     .map(([_state, count]) => count)
     .reduce((sum, val) => sum + val, 0);
-  let newTabs = tabs;
-
-  if (taskInstance && taskInstance.map_index > -1) {
-    newTabs = [
-      ...tabs.slice(0, 1),
-      {
-        icon: <MdOutlineTask />,
-        label: translate("tabs.mappedTaskInstances_other", {
-          count: Number(taskCount),
-        }),
-        value: "task_instances",
-      },
-      ...tabs.slice(1),
-    ];
-  }
+  const newTabs =
+    taskInstance && taskInstance.map_index > -1
+      ? [
+          ...tabs.slice(0, 1),
+          {
+            icon: <MdOutlineTask />,
+            label: translate("tabs.mappedTaskInstances_other", {
+              count: Number(taskCount),
+            }),
+            value: "task_instances",
+          },
+          ...tabs.slice(1),
+        ]
+      : tabs;
 
   const { tabs: requiredActionTabs } = useRequiredActionTabs({ dagId, dagRunId: runId, taskId }, newTabs, {
     autoRedirect: true,

airflow-core/src/airflow/ui/src/utils/datetimeUtils.test.ts

@@ -70,7 +70,7 @@ describe("getDuration & formatDuration", () => {
     expect(getDuration(null, null)).toBe(undefined);
     expect(getDuration(undefined, undefined)).toBe(undefined);
     expect(getDuration(null, "2024-03-14T10:00:10.000Z")).toBe(undefined);
-    expect(renderDuration(0.000_01)).toBe(undefined);
+    expect(renderDuration(0.00001)).toBe(undefined);
   });
 
   it("falls back to current time when endDate is null (running task)", () => {
@@ -91,12 +91,12 @@ describe("getDuration & formatDuration", () => {
   });
 
   it("handles floating point milliseconds", () => {
-    expect(renderDuration(dayjs.duration(10.000_499_738, "seconds"))).toBe("00:00:10");
-    expect(renderDuration(10.000_499_738)).toBe("00:00:10");
-    expect(renderDuration(dayjs.duration(10.000_500, "seconds"))).toBe("00:00:10.001");
-    expect(renderDuration(10.000_500)).toBe("00:00:10.001");
-    expect(renderDuration(dayjs.duration(10.838_999_738, "seconds"))).toBe("00:00:10.839");
-    expect(renderDuration(10.838_999_738)).toBe("00:00:10.839");
+    expect(renderDuration(dayjs.duration(10.000499738, "seconds"))).toBe("00:00:10");
+    expect(renderDuration(10.000499738)).toBe("00:00:10");
+    expect(renderDuration(dayjs.duration(10.0005, "seconds"))).toBe("00:00:10.001");
+    expect(renderDuration(10.0005)).toBe("00:00:10.001");
+    expect(renderDuration(dayjs.duration(10.838999738, "seconds"))).toBe("00:00:10.839");
+    expect(renderDuration(10.838999738)).toBe("00:00:10.839");
   });
 });