ARROW-3172: [Rust] Update documentation for datatypes.rs - #2513
ARROW-3172: [Rust] Update documentation for datatypes.rs#2513paddyhoran wants to merge 5 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2513 +/- ##
==========================================
+ Coverage 86.33% 87.49% +1.15%
==========================================
Files 308 259 -49
Lines 47120 44797 -2323
==========================================
- Hits 40682 39194 -1488
+ Misses 6366 5603 -763
+ Partials 72 0 -72Continue to review full report at Codecov.
|
| } | ||
| } | ||
|
|
||
| /// Returns a immutable reference to the `Field`'s name |
| &self.name | ||
| } | ||
|
|
||
| /// Returns a immutable reference to the `Field`'s data-type |
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| /*! |
There was a problem hiding this comment.
Shouldn't this use //! style comments instead?
There was a problem hiding this comment.
I believe that surrounding with /*! and */ is equivalent to starting each line with //!. I'm finding it hard to confirm this but I noticed this approach here
I guess we should stick with //! as it seems to be most used approach.
|
@kszucs @andygrove I'm not sure why the windows build failed. The previous commit only failed the non-windows build because thats where we run the I just ran everything locally on windows and it's all good, I think Appveyor just timed out or something. I think this should be good to merge (not sure how to re-trigger CI without making changes to confirm my theory), what do you think? |
|
It was a temporary network issue. Thanks @paddyhoran! |
4 participants
No description provided.