Skip to content

HBASE-23832 Old config hbase.hstore.compactionThreshold is ignored - #1674

Merged
anoopsjohn merged 1 commit into
apache:masterfrom
mohapatrasambit:HBASE-23832
May 12, 2020
Merged

HBASE-23832 Old config hbase.hstore.compactionThreshold is ignored#1674
anoopsjohn merged 1 commit into
apache:masterfrom
mohapatrasambit:HBASE-23832

Conversation

@mohapatrasambit

Copy link
Copy Markdown
Contributor

Updated default value hbase.hstore.compaction.min to null

With this change if user uses old key "hbase.hstore.compactionThreshold", then it will take effect. If user doesn't define any then default value of null, will result in 3 for minFilesToComapct, which is expected.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 10s master passed
-0 ⚠️ javadoc 0m 19s hbase-common in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 58s the patch passed
-0 ⚠️ javadoc 0m 18s hbase-common in the patch failed.
_ Other Tests _
+1 💚 unit 1m 33s hbase-common in the patch passed.
11m 57s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1674
Optional Tests javac javadoc unit
uname Linux b25ebd3076a5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f4a446c
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/testReport/
Max. process+thread count 276 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 36s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 39s master passed
+1 💚 javadoc 0m 25s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 12s the patch passed
+1 💚 javadoc 0m 22s the patch passed
_ Other Tests _
+1 💚 unit 1m 49s hbase-common in the patch passed.
14m 16s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1674
Optional Tests javac javadoc unit
uname Linux 79b0ff89044e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f4a446c
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/testReport/
Max. process+thread count 223 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 53s master passed
+0 🆗 refguide 4m 49s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 29s the patch passed
-0 ⚠️ whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+0 🆗 refguide 4m 44s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
19m 20s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1674
Optional Tests dupname asflicense refguide xml
uname Linux ce963e48533c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f4a446c
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-general-check/output/branch-site/book.html
whitespace https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-general-check/output/whitespace-eol.txt
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 79 (vs. ulimit of 12500)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1674/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@infraio infraio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@anoopsjohn
anoopsjohn merged commit c4e892e into apache:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants