HBASE-24792 return value of LogRoller.walRollFinished may be wrong#2169
Closed
WenFeiYi wants to merge 3 commits intoapache:masterfrom
Closed
HBASE-24792 return value of LogRoller.walRollFinished may be wrong#2169WenFeiYi wants to merge 3 commits intoapache:masterfrom
WenFeiYi wants to merge 3 commits intoapache:masterfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
Aug 10, 2020
| } finally { | ||
| this.isRolling = false; | ||
| synchronized (RollController.class) { | ||
| RollController.class.notifyAll(); |
Contributor
There was a problem hiding this comment.
Usually a dummy notifyAll without any flag in the same synchronized block will have race... Mind explain a bit what is the problem we want to fix here?
Contributor
Author
There was a problem hiding this comment.
The LogRoller.walRollFinished impl is already buggy. This just checks the status of the boolean. Once we start a roll on a WAL, we reset the boolean (Even before patch HBASE-24665). So it is not clearly telling anything about the roll status. This can return true even while an active wal roll is going on.
We might need another boolean in Controller which clearly tracks whether we are ongoing a roll.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Apache9
requested changes
Oct 13, 2020
Contributor
Apache9
left a comment
Apache9
left a comment
There was a problem hiding this comment.
Please change the title to bette describe what are we trying to fix here? And is it possible to add a UT?
| private final WAL wal; | ||
| private final AtomicBoolean rollRequest; | ||
| private long lastRollTime; | ||
| private boolean isRolling; |
Contributor
There was a problem hiding this comment.
I think this field will be accessed by multiple threads so a simple boolean it not enough to keep us safe?
WenFeiYi
changed the title
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
OK, so the problem here is that, walRollFinished returns true but the roll has not been finished yet? Maybe we need to define the exact semantic of this method first... Usually we will call requestRoll first and then call this method? What if there is already a roll in place when we call requestRoll? Thanks. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.