HBASE-24806 Small Updates to Functionality of Shell IRB Workspace#2232
Merged
saintstack merged 2 commits intoapache:masterfrom Aug 18, 2020
Merged
HBASE-24806 Small Updates to Functionality of Shell IRB Workspace#2232saintstack merged 2 commits intoapache:masterfrom
saintstack merged 2 commits intoapache:masterfrom
Conversation
- Move exception handler from Shell::Shell#eval_io to new method, Shell::Shell#exception_handler - Add unit tests for Shell::Shell#exception_handler - Change Shell::Shell#eval_io to no longer raise SystemExit when any error is seen and update unit test - Update ruby test runner to catch SystemExit and fail to avoid tests that cause the test runner to incorrectly exit successfully - Add Hbase::Loader module to find ruby scripts in the $LOAD_PATH and classpath using JRuby's loader. - In hbase-shell, install IRB commands before exporting HBase commands. The HBase commands will override the IRB commands, and no warning will be printed.
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
approved these changes
Aug 10, 2020
Member
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
+1 from me, though maybe someone with more ruby experience should have a look.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Seems like none of the unit test failures are caused by this patch.
|
Contributor
Author
Member
|
@bitoffdev do you know how to find the test log files? I'm looking at PR-2232/1/artifact/yetus-jdk11-hadoop3-check/output, there's a file called test_logs.zip in the Jenkins build archive. In that archive, I find the |
Member
|
There's also, |
Contributor
|
@bitoffdev You see Nick's comments above boss? |
saintstack
reviewed
Aug 18, 2020
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
I like the idea of removing exception spew. Maybe shove a before and after up in the JIRA for folks to see?
Contributor
Author
The end-user functionality hasn't changed. This functionality used to exist in |
Contributor
Author
|
Also, the failures mentioned by @ndimiduk are described and fixed by https://issues.apache.org/jira/browse/HBASE-24874. They are unrelated to this patch. |
asfgit
pushed a commit
that referenced
this pull request
Oct 14, 2020
) * HBASE-24806 Small Updates to Functionality of Shell IRB Workspace - Move exception handler from Shell::Shell#eval_io to new method, Shell::Shell#exception_handler - Add unit tests for Shell::Shell#exception_handler - Change Shell::Shell#eval_io to no longer raise SystemExit when any error is seen and update unit test - Update ruby test runner to catch SystemExit and fail to avoid tests that cause the test runner to incorrectly exit successfully - Add Hbase::Loader module to find ruby scripts in the $LOAD_PATH and classpath using JRuby's loader. - In hbase-shell, install IRB commands before exporting HBase commands. The HBase commands will override the IRB commands, and no warning will be printed. * Remove unused variables from shell_test Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> (cherry picked from commit 98e3584)
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…ache#2232) * HBASE-24806 Small Updates to Functionality of Shell IRB Workspace - Move exception handler from Shell::Shell#eval_io to new method, Shell::Shell#exception_handler - Add unit tests for Shell::Shell#exception_handler - Change Shell::Shell#eval_io to no longer raise SystemExit when any error is seen and update unit test - Update ruby test runner to catch SystemExit and fail to avoid tests that cause the test runner to incorrectly exit successfully - Add Hbase::Loader module to find ruby scripts in the $LOAD_PATH and classpath using JRuby's loader. - In hbase-shell, install IRB commands before exporting HBase commands. The HBase commands will override the IRB commands, and no warning will be printed. * Remove unused variables from shell_test Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: stack <stack@apache.org> (cherry picked from commit 98e3584)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.apache.org/jira/browse/HBASE-24806
High-Level Overview
can't alias help from irb_help).load, including files inside a Jar. It is necessary so that our shell can evaluate scripts in the $LOAD_PATH/classpath.Changelog
Shell::Shell#exception_handler
seen and update unit test
cause the test runner to incorrectly exit successfully
using JRuby's loader.
HBase commands will override the IRB commands, and no warning will be
printed.