HBASE-25439 Add BYTE unit in PrettyPrinter.Unit#2812
Merged
saintstack merged 2 commits intoapache:masterfrom Jan 3, 2021
Merged
HBASE-25439 Add BYTE unit in PrettyPrinter.Unit#2812saintstack merged 2 commits intoapache:masterfrom
saintstack merged 2 commits intoapache:masterfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Dec 28, 2020
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
This is a nice addition.
Just a minor in the below.
| assertEquals( | ||
| "'testStringCustomizedValues', " + | ||
| "{TABLE_ATTRIBUTES => {DURABILITY => 'ASYNC_WAL', " | ||
| + "MAX_FILESIZE => '10737942528 B (10 GB 512 KB)'}}, {NAME => 'cf', BLOCKSIZE => '1000'}", |
Contributor
There was a problem hiding this comment.
Does it have to have a space between the number and the unit? Can it be 10GB instead of '10 GB'?
Contributor
Author
There was a problem hiding this comment.
I copied the pretty print format of TTL. But I‘m with you, the space is not necessary. Will update.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
PR looks good. The failure seems unrelated in hbase-common (it timed out). There maybe an issue recently introduced unrelated to this PR. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-25439
Add a new unit 'BYTE' to pretty print value of size, such as MAX_FILESIZE, MEMSTORE_FLUSHSIZE