HBASE-26089 Support RegionCoprocessor on CompactionServer#3499
Closed
nyl3532016 wants to merge 5 commits intoapache:HBASE-25714from
Closed
HBASE-26089 Support RegionCoprocessor on CompactionServer#3499nyl3532016 wants to merge 5 commits intoapache:HBASE-25714from
nyl3532016 wants to merge 5 commits intoapache:HBASE-25714from
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Jul 26, 2021
Contributor
Apache9
left a comment
Apache9
left a comment
There was a problem hiding this comment.
I still can not get the whole picture about how to support CP in CompactionServer.
Better have a special section in the design doc on CP support?
| @Override | ||
| public RegionEnvironment createEnvironment(RegionCoprocessor instance, int priority, int seq, | ||
| Configuration conf) { | ||
| if (coprocessorService instanceof HCompactionServer) { |
Contributor
There was a problem hiding this comment.
Could we add some configs to avoid instanceof here, or we sub class RegionCoprocessorHost?
Contributor
Author
There was a problem hiding this comment.
Yes, We can introduce RegionCompactionCoprocessorHost which only used for CompactionServer
Contributor
+1. When we can support CP and when we can not support it. Can you pls explain in a doc |
Contributor
Author
|
@Apache9 @anoopsjohn, I have supplement Region Coprocessor Support section in design doc, mind have a look at your convenience. |
|
💔 -1 overall
This message was automatically generated. |
1 similar comment
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
1 similar comment
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two kinds of RegionCoprocessor: CoreCoprocessor or not.
1.The CoreCoprocessor(AccessController, TokenProvider, SecureBulkLoadEndpoint...), They have RegionEnvironmentForCoreCoprocessors which expose RegionServerServices. And they involve authorization, permission, etc, We don't need to support these CoreCoprocessor on compactionServer
2. Not CoreCoprocessor: They have RegionEnvironment which do not expose RegionServerServices, only offer Connection/ OnlineRegions, We can propose RegionCoprocessorService, offer Connection, but the OnlineRegions may not be supported