HBASE-26088 Fix thread leaks in conn#getBufferedMutator(tableName) method call#3506
Merged
anoopsjohn merged 3 commits intoapache:branch-2from Jul 21, 2021
Merged
Conversation
added 2 commits
July 19, 2021 16:46
Contributor
Author
|
@saintstack @anoopsjohn @apurtell This PR is just for branch-2. The behavior is different in master branch. In master brach, there is only AsyncConnection and I don't see it creating a new ThreadPoolExecutor but still studying master code base. Please review. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
approved these changes
Jul 20, 2021
Contributor
anoopsjohn
left a comment
anoopsjohn
left a comment
There was a problem hiding this comment.
Just a nit.
This issue is not there in branch-1 anyways right?
So for all branch-2 branches, we are sticking with the existing behaviour to have the compatibility and correcting the Javadoc. Pls mark this issue accordingly and we can address master branch (3.x also?) in another task. There we can even change to use the current javadoc way of using Connection's pool (If bug is there still)
| * use the Connection's ExecutorService. This object can be used for long lived operations. | ||
| * {@link BufferedMutator} returned by this method is thread-safe. | ||
| * This accessor will create a new ThreadPoolExecutor and will be shutdown once we close the | ||
| * BufferedMutator. This object can be used for long lived operations. |
Contributor
There was a problem hiding this comment.
Nit: May be for API getBufferedMutator(BufferedMutatorParams params) we can say clearly that if user passes a ThreadPool in params, we will use that or else same as this method (new one and handled by us on close)
Contributor
Author
There was a problem hiding this comment.
@anoopsjohn Done ! Please review again !
Contributor
branch-1 seems no such issue, because there's no this flag |
Reidddddd
approved these changes
Jul 20, 2021
Apache9
approved these changes
Jul 20, 2021
anoopsjohn
approved these changes
Jul 20, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 21, 2021
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Great. Needs release note.
anoopsjohn
pushed a commit
that referenced
this pull request
Jul 21, 2021
…thod call (#3506) Co-authored-by: Rushabh Shah <rushabh.shah@rushabh-ltmflld.internal.salesforce.com> Signed-off-by: zhangduo <zhangduo@apache.org> Signed-off-by: Anoop <anoopsamjohn@apache.org> Signed-off-by: stack <stack@duboce.net> Signed-off-by: Reid Chan <reidchan@apache.org>
anoopsjohn
pushed a commit
that referenced
this pull request
Jul 21, 2021
…thod call (#3506) Co-authored-by: Rushabh Shah <rushabh.shah@rushabh-ltmflld.internal.salesforce.com> Signed-off-by: zhangduo <zhangduo@apache.org> Signed-off-by: Anoop <anoopsamjohn@apache.org> Signed-off-by: stack <stack@duboce.net> Signed-off-by: Reid Chan <reidchan@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.