arch/tricore: add support for tc4xx series chips and boards#18391
arch/tricore: add support for tc4xx series chips and boards#18391zhangyu-duck wants to merge 7 commits intoapache:masterfrom
Conversation
7682822 to
31c2ea0
Compare
| /********************************************************************************************************************** | ||
| * \file Ifx_Cfg_Ssw.c | ||
| * \brief Configuration file for the Startup Software | ||
| * \copyright Copyright (C) Infineon Technologies AG 2019 |
There was a problem hiding this comment.
Can Ifx_*.c use the iLLD implementation?I'm not sure if introducing Infineon's license is feasible, or could we submit the differences as a patch file?
There was a problem hiding this comment.
We feel that these files may still be changed in the future, and it's not convenient to upload them as a patch list.
i have rewrite them and only keep something we need. and replace with SPDX license.
745ed4d to
4edecbe
Compare
jerpelea
left a comment
There was a problem hiding this comment.
please document all non Apache license file to
https://github.com/apache/nuttx/blob/master/LICENSE
jerpelea
left a comment
There was a problem hiding this comment.
please add SPDX license identifiers to all files not only Apache licensed ones
4edecbe to
d2a6f48
Compare
ok,thanks, i have updata code |
get it, thanks |
acassis
left a comment
There was a problem hiding this comment.
@zhangyu-duck please update the Documentation https://nuttx.apache.org/docs/latest/platforms/tricore/index.html to include these new chips.
Unfortunately our Documentation is very non-standardized, some Documentation arch are very good, others are very primitive (let say not helpful). So, I suggest you to use https://nuttx.apache.org/docs/latest/platforms/arm/imxrt/index.html as a good reference.
arch/tricore/src/illd/tc4xx/Libraries/doc/iLLD-TC4xx-Releasenotes.pdf
Outdated
Show resolved
Hide resolved
linguini1
left a comment
There was a problem hiding this comment.
I guess since this modifies the TC3xx logic as well, could you please include an OSTest log from a tc3 board? The tc4 log looks good.
| select UART0_SERIALDRIVER | ||
| select ARCH_HAVE_SERIAL_TERMIOS | ||
|
|
||
| config CPU_COREID |
There was a problem hiding this comment.
It's may better to use the same name, so that the common upper-level code of TC3/TC4 doesn't need to be modified.
There was a problem hiding this comment.
I would suggest moving the config option to a higher level tricore Kconfig then, one that's common to both.
|
Also I won't block the PR about this since I have pretty much no familiarity with the tricore architecture, but is it necessary to use the SDK? It seems like this PR needs to include a lot of workarounds for quirks with the SDK (like the libc stubs and patch files). Is it at all possible to avoid using the SDK directly? I know a few other archs in NuttX use this approach (hence why I don't think it's a dealbreaker or anything), but I also know the preferred method is to avoid using vendor SDKs/HALs entirely if possible. |
perform type conversion to eliminate warnings Signed-off-by: zhangyuan29 <zhangyuan29@xiaomi.com>
add arch.h in irq.h Signed-off-by: zhangyuan29 <zhangyuan29@xiaomi.com>
tc3 and tc4 use common irq.h Signed-off-by: zhangyu117 <zhangyu117@xiaomi.com>
support tc4evb board, so need adjust some Kconfig Signed-off-by: zhangyu117 <zhangyu117@xiaomi.com>
rename tc3xx.cmake to chip.cmake Signed-off-by: zhangyuan29 <zhangyuan29@xiaomi.com>
Let the linker script decide the location of the heap. Signed-off-by: zhangyuan29 <zhangyuan29@xiaomi.com>
Sorry, Infineon's Tricore chip heavily relies on ILLD's library functions, making it difficult to render effectively. The original TC3 series chips also did this before. |
ok, get it |
|
d2a6f48 to
c194f89
Compare
add new chip named tc4xx and board tc4evb Signed-off-by: zhangyu117 <zhangyu117@xiaomi.com>
c194f89 to
c080e06
Compare
|
@simbit18 do you know if LVGL v9.2 files were removed from their site? We need to create our own mirror at github.com/nuttx/ |
On this note, we are already in the phase of developing iLLD independent Tricore support. Although this isn't mature yet, plans are tracked here 1. Also you can find development tree with various branches 2 named |
Woah awesome news! Thanks! |
|
@zhangyu-duck are these changes tested with Tasking only or OSS GCC can also be used? |
Note: Please adhere to Contributing Guidelines.
Summary
Two main updates:
Impact
support tc4xx chip
Testing
nsh> hello
Hello, World!! tc4 ostest
nsh>
i give tc4 ostest.log in attach files
tc4_ostest.log