tools/nxstyle: Whitelist Micro XRCE-DDS uxrCustomTransport prefix#19006
Merged
xiaoxiang781216 merged 1 commit intoJun 1, 2026
Merged
Conversation
The Micro XRCE-DDS Client custom-transport API expects user callbacks with prototypes of the form bool open_cb (struct uxrCustomTransport *transport); size_t read_cb(struct uxrCustomTransport *transport, ...); The struct tag is fixed by the upstream public header <uxr/client/profile/transport/custom/custom_transport.h> and cannot be renamed. nxstyle currently flags every callback signature in apps/system/microros/transport with 'Mixed case identifier found'. Add the 'uxrCustom' prefix to g_white_prefix, following the same pattern used for the ROS 2 message type names added in commit bc3a259 ("tools/nxstyle: Whitelist ROS 2 message type identifiers."). Signed-off-by: Arjav Patel <arjav1528@gmail.com>
acassis
approved these changes
May 31, 2026
xiaoxiang781216
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to bc3a259 (
tools/nxstyle: Whitelist ROS 2 message type identifiers.). The Micro XRCE-DDS Client custom-transport APIexpects user callbacks of the form
The
uxrCustomTransporttag is fixed by the upstream public header<uxr/client/profile/transport/custom/custom_transport.h>and cannotbe renamed without breaking the Micro XRCE-DDS C API.
Add the
uxrCustomprefix tog_white_prefixsonxstylestopsflagging every callback signature in the upcoming
apps/system/microros/transportbackend witherror: Mixed case identifier found.Impact
tools/nxstyleonly. No build, runtime, or hardware effect.identifier prefix. No existing in-tree code becomes invalid.
Dependencies
Companion to apache/nuttx-apps#3512 (
system/microros: Add UDP and serial custom transports). That PR's CInxstylestep otherwisefails on every
struct uxrCustomTransport *parameter in the newtransport backend (~20 errors across 4 files).
Testing
Local build of the patched
tools/nxstyleand run against the fourtransport files plus the publisher example in apache/nuttx-apps#3512:
Before this patch (same nxstyle build minus the new whitelist
entry):