Extract CLIUtils.solrUrlFromConnection() from normalizeSolrUrl(CommandLine) - #4683
Merged
Merged
Conversation
…dLine) Makes the connection-string-to-Solr-URL resolution reusable outside of commons-cli contexts. No behavior change.
epugh
approved these changes
Jul 30, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
I think this also would address the comment on #4672 (comment) and make that PR better.... I was stuggling a bit on understanding that chain of logic when I was working on #4672, and here you did it independently!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the connection-string-to-Solr-URL resolution logic added in SOLR-18130 (HTTP form used directly; ZooKeeper form queried for a live node's base URL) out of the commons-cli-coupled
normalizeSolrUrl(CommandLine)into a reusable public helpersolrUrlFromConnection(CloudSolrClientConnection, credentials). The commons-cli path delegates to it, so there is no behavior change.This makes the resolution reusable outside commons-cli contexts — e.g. the picocli migration branch (#3254) needs it — and landing it on main independently keeps non-picocli drift off that long-running branch.