Correct LANGUAGES.md entries flagged after the matrix update - #3834
Conversation
Client: docs Follow-up to PR apache#3820. Each cell below was checked against the source at 5c5e93e rather than carried over: - Java SE tested levels 8 and 17, not 11 and 19: CI builds on JDK 17 and runs the cross-tests on Java 8, and sourceConfiguration.gradle sets a JDK 17 toolchain with options.release = 8. - Rust TLS, domain sockets and ThreadPool: the rustls feature in Cargo.toml with TTlsClientChannel and TServer::listen_tls, TServer::listen_uds under #[cfg(unix)], and TServer's fixed-size worker pool. - Python Memory and Framed transports, and the Threaded and ThreadPool servers: TMemoryBuffer, TFramedTransport, TThreadedServer and TThreadPoolServer. - Kotlin level 2.4.10, not 1.8, which is the JVM bytecode target: the Kotlin version comes from settings.gradle.kts. Multiplex, zlib, Nonblocking and ThreadPool are exercised by the cross-test server over the Java runtime. - Haxe Memory transport: TMemoryStream, with round-trip coverage in StreamTest. Rust still shows a single server type, a fixed-size pool, marked as both Threaded and ThreadPool. That one is left alone here. Adds a notes section for the conditions a single cell cannot carry: the rustls feature is off by default, listen_uds is Unix-only, and the Java and Kotlin rows report tested bounds rather than a maximum supported release.
|
While table looks nice maybe it coudl be somehow reorganized to some capabilities and more verbose clarification that this capability means for specific language. For example Go port is in many places marked as "not supported" due to different architecture. |
HTHou
left a comment
There was a problem hiding this comment.
Thanks for following up! The changes address all the entries raised in the two comments on #3820, and the added notes clarify the platform, feature and version conditions.
Reviewed the documentation changes against the source and build configuration with AI assistance; I did not rerun the test suite locally. No blocking issues found in this diff. The Rust Threaded/ThreadPool terminology can be discussed separately.
Follow-up to #3820, addressing the two review comments there. Every entry was checked against the source at 5c5e93e; nothing here is carried over from the earlier matrix.
build.ymlbuilds on JDK 17 and runs the cross-tests on Java 8;sourceConfiguration.gradlesets a JDK 17 toolchain withoptions.release = 8rustlsfeature inCargo.toml, withTTlsClientChannel::connectandTServer::listen_tlsTServer::listen_uds, under#[cfg(unix)]TServerholds aThreadPoolsized bynum_workersTMemoryBufferandTFramedTransportTThreadedServerandTThreadPoolServersettings.gradle.ktsuseskotlin("jvm") version "2.4.10"; 1.8 is the bytecode target, not the Kotlin versionTMultiplexedProcessor,TZlibTransport,TNonblockingServerandTThreadPoolServerover the Java runtimeTMemoryStream, with round-trip coverage inStreamTest.hxThe table has no way to carry a condition, so this adds a short notes section for three of them: the
rustlsfeature is off by default,listen_udsis Unix-only, and the Java and Kotlin rows report tested bounds rather than a maximum supported release.One entry is deliberately left alone. Rust has a single server type, a fixed-size worker pool, and the row marks it as both Threaded and ThreadPool. Marking ThreadPool is right; whether Threaded should stay is a separate judgement, and I did not want to fold it into a corrections PR.
Thanks @HTHou for the two lists. The claims held up on inspection.
This change was created with AI assistance.