To: INternal server error when server capability associated with Server/ds is deleted

[lbathina]

I'm submitting a ...

• bug report
• new feature / enhancement request
• improvement request (usability, performance, tech debt, etc.)
• other

Traffic Control components affected ...

• CDN in a Box
• Documentation
• Grove
• Traffic Control Client
• Traffic Monitor
• Traffic Ops
• Traffic Ops ORT
• Traffic Portal
• Traffic Router
• Traffic Stats
• Traffic Vault
• unknown

Current behavior:

When a server capability associated with a server is deleted, we get internal server error

Expected / new behavior:

Should return error Server capability <name> cannot be deleted when servers are associated to it.

Minimal reproduction of the problem with instructions:

1. create server capability
2. Associate it to a server
3. delete the server capability created in step1

Anything else:

[ocket8888]

Error code should be 409 Conflict IMO.

[lbathina]

same issue appears while deleting a server capability associated to a delivery service

[mitchell852]

this is a bug, not an improvement. deleting a server capability that is assigned to a server or a ds should result in a 400 Bad Request (i think this is normal functionality) or a 409 like @ocket8888 suggested if you want to do it better.

[lbathina]

this has been validated, works fine for TO. TP doesn't show any message- needs to be fixed for TP

[lbathina]

/reopen pls

[lbathina]

also the message displayed for api is partially correct {"alerts":[{"text":"cannot delete server_capability because it is being used by a server_server_capability","level":"error"}]}
it could be server_server_capability or required capability - can this be updated to user friendly message without exposing db tables?