Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@mhoppa
Copy link
Contributor

@mhoppa mhoppa commented Oct 29, 2019

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Create a server capability assign it to a server or ds and then attempt to delete it. It should now return a 400 instead of a 500.

If this is a bug fix, what versions of Traffic Control are affected?

master

The following criteria are ALL met by this PR

  • This PR includes tests
  • I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@asf-ci
Copy link
Contributor

asf-ci commented Oct 29, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4668/

@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Oct 30, 2019
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass, manual test confirmed it works.

@ocket8888 ocket8888 merged commit c02dfaa into apache:master Oct 30, 2019
@mhoppa mhoppa deleted the bug/fix_regex_on_err_handling branch October 30, 2019 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

To: INternal server error when server capability associated with Server/ds is deleted

3 participants