This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Updated profiles and parameters test to clean up parameters better#3100
Merged
Conversation
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
…eters delete test so that it checks whether or not a parameter was deleted by id instead of name and config.
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
17 tasks
mitchell852
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Updated profile test to delete parameters it generates. Updated parameters delete test so that it checks whether or not a parameter was deleted by id instead of name and config (If there happens to be a parameter created by a profile there is a conflict).
How to verify this PR
Checkout the first commit, build traffic ops, run
go test -run TestPand check the database to make sure no parameters exist. Repeat for the second commit. The first commit should show the problem, and the second should fix it.Which TC components are affected by this PR?
This PR adds data to
tc-fixtures.json, then modifies the tests so that they still pass. The data intc-fixtures.jsonI will need to use.Check all that apply