Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@svairamani
Copy link

@svairamani svairamani commented Oct 18, 2019

What does this PR (Pull Request) do?

Generates Jacoco Reports for TR

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Router - Does not affect the functionality of TR .Provides the unit test coverage for TR Component. No documentation, changelog required.

What is the best way to verify this PR?

Pull this PR
Run mvn test from traffic_router directory
Verify Jacoco reports generated at :
traffic_router\core\target\site\jacoco\index.html
traffic_router\shared\target\site\jacoco\index.html
traffic_router\connector\target\site\jacoco\index.html
traffic_router\geolocation\target\site\jacoco\index.html

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

image

To include jacoco maven plugin.
Changes to avoid conflict of argLine parameters with maven-surefire for Jacoco
@asf-ci
Copy link
Contributor

asf-ci commented Oct 18, 2019

Can one of the admins verify this patch?

@mitchell852 mitchell852 added Traffic Router related to Traffic Router tests related to tests and/or testing infrastructure labels Oct 18, 2019
@ericholguin
Copy link
Contributor

This was added in #7230

@ericholguin ericholguin closed this Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests related to tests and/or testing infrastructure Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants