Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ericholguin
Copy link
Contributor

Adds the jacoco plugin in order to enable code coverage reports
Codecov can leverage these report results to determine test coverage


Which Traffic Control components are affected by this PR?

  • Traffic Router (pom.xml)
  • GitHub Actions

What is the best way to verify this PR?

Verify the TR Test GHA runs successfully
Verify Codecov report is successfully uploaded

PR submission checklist

@ericholguin ericholguin changed the title Add Traffic Router unit tests too Codecov Add Traffic Router unit tests to Codecov Dec 2, 2022
<showDeprecation>true</showDeprecation>
</configuration>
</plugin>
<plugin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs <scope>test</scope> so jacoco doesn't get included in RPMs

</configuration>
</plugin>
<plugin>
<groupId>org.jacoco</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs <scope>test</scope> so jacoco doesn't get included in RPMs

@zrhoffman zrhoffman added tests related to tests and/or testing infrastructure improvement The functionality exists but it could be improved in some way. logging related to logging infrastructure process tech debt rework due to choosing easy/limited solution labels Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #7230 (52a788c) into master (2ab9ffd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master    #7230    +/-   ##
==========================================
  Coverage     28.35%   28.36%            
- Complexity        0       98    +98     
==========================================
  Files           589      617    +28     
  Lines         68241    69195   +954     
  Branches          0       90    +90     
==========================================
+ Hits          19347    19624   +277     
- Misses        47117    47760   +643     
- Partials       1777     1811    +34     
Flag Coverage Δ
traffic_router_unit 29.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntrol/traffic_router/secure/PrivateKeyDecoder.java 66.66% <0.00%> (ø)
...control/traffic_router/protocol/LanguidPoller.java 0.00% <0.00%> (ø)
...he/traffic_control/traffic_router/secure/Pkcs.java 40.90% <0.00%> (ø)
...ol/traffic_router/protocol/LanguidNioProtocol.java 0.00% <0.00%> (ø)
...traffic_router/tomcat/TomcatLifecycleListener.java 0.00% <0.00%> (ø)
...control/traffic_router/protocol/RouterSslUtil.java 0.00% <0.00%> (ø)
...affic_router/geolocation/GeolocationException.java 0.00% <0.00%> (ø)
...rol/traffic_router/secure/Pkcs1KeySpecDecoder.java 0.00% <0.00%> (ø)
...fic_control/traffic_router/shared/Certificate.java 46.66% <0.00%> (ø)
...raffic_router/secure/CertificateDataConverter.java 65.51% <0.00%> (ø)
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@zrhoffman zrhoffman merged commit 9bb5ad5 into apache:master Dec 3, 2022
@ericholguin ericholguin mentioned this pull request Aug 9, 2023
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. logging related to logging infrastructure process tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants