Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Update CDN in a Box to CentOS 8#5252

Merged
ocket8888 merged 12 commits intoapache:masterfrom
zrhoffman:ciab-centos-8
Nov 17, 2020
Merged

Update CDN in a Box to CentOS 8#5252
ocket8888 merged 12 commits intoapache:masterfrom
zrhoffman:ciab-centos-8

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Nov 5, 2020

What does this PR (Pull Request) do?

Depends on #5262 (merged), drafted until #5262 is closed.

  • This PR is not related to any Issue

This PR bases the CDN in a Box Docker images off of CentOS 8 by default but allows users to continue to use CentOS 7 if they want by specifying the CENTOS_VERSION docker-compose build arg.

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Documentation

What is the best way to verify this PR?

  • Build and run CDN in a Box normally, make sure it works.

    export DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1
    docker-compose build --parallel
    docker-compose down -v
    docker-compose up
  • Build and run CDN in a Box with CentOS 7 images, make sure it works.

    export DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1
    docker-compose build --parallel --build-arg CENTOS_VERSION=7
    docker-compose down -v
    docker-compose up

The following criteria are ALL met by this PR

  • This PR changes CDN-in-a-Box, which is a test
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman zrhoffman added cdn-in-a-box related to the Docker-based CDN-in-a-Box system new feature A new feature, capability or behavior tech debt rework due to choosing easy/limited solution labels Nov 5, 2020
@zrhoffman zrhoffman marked this pull request as draft November 5, 2020 22:26
@zrhoffman zrhoffman marked this pull request as ready for review November 6, 2020 14:38
@zrhoffman
Copy link
Member Author

Fixed a file permissions issue in 9b7751cd2d. PR is ready for review.

@zrhoffman
Copy link
Member Author

Rebased to resolve merge conflicts

@zrhoffman zrhoffman marked this pull request as draft November 7, 2020 06:19
@zrhoffman
Copy link
Member Author

Depends on #5262, drafting for now

@zrhoffman zrhoffman requested a review from ocket8888 November 9, 2020 17:11
@zrhoffman zrhoffman marked this pull request as ready for review November 9, 2020 18:32
@zrhoffman
Copy link
Member Author

Undrafted, #5252 is ready for review.

@zrhoffman
Copy link
Member Author

Rebased to fix a merge conflict in the changelog

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests say it's working, and I can't see anything wrong with it.

@ocket8888 ocket8888 merged commit a4a8700 into apache:master Nov 17, 2020
@zrhoffman zrhoffman deleted the ciab-centos-8 branch November 17, 2020 00:54
ocket8888 pushed a commit that referenced this pull request Nov 18, 2020
* Use CentOS 8 for CDN-in-a-Box images by default

* Use dnf instead of yum

* If on CentOS 8, enable additional repositories before trying to install
packages

* Install python3 packages, not python36

* Specify additional packages to install that would have been
automatically installed on CentOS 7

* Use Traffic Server built for CentOS 7 on CentOS 8

* Update for openssl 1.1: Open permissions on generated certs

* We only need certs to be world-readable, not world-writable

* Alpine Linux is not based on CentOS

* Strip potential minor version from CENTOS_VERSION before using in repo RPM URL

* Make Traffic Portal UI tests Dockerfile CentOS 8-compatible

* More reliable way of deriving major version from CENTOS_VERSION that
will work with CentOS 10

(cherry picked from commit a4a8700)
@zrhoffman zrhoffman added the os label Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cdn-in-a-box related to the Docker-based CDN-in-a-Box system new feature A new feature, capability or behavior os tech debt rework due to choosing easy/limited solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants