This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Update CDN in a Box to CentOS 8#5252
Merged
ocket8888 merged 12 commits intoapache:masterfrom Nov 17, 2020
Merged
Conversation
fab6332 to
b5588d1
Compare
Member
Author
|
Fixed a file permissions issue in 9b7751cd2d. PR is ready for review. |
3585325 to
309774b
Compare
Member
Author
|
Rebased to resolve merge conflicts |
309774b to
54d6a6e
Compare
Member
Author
|
Depends on #5262, drafting for now |
54d6a6e to
2c19cac
Compare
Member
Author
|
Undrafted, #5252 is ready for review. |
2c19cac to
75ad7ab
Compare
ocket8888
reviewed
Nov 9, 2020
f2feec2 to
5afc4d4
Compare
Member
Author
|
Rebased to fix a merge conflict in the changelog |
automatically installed on CentOS 7
5afc4d4 to
29bc698
Compare
ocket8888
reviewed
Nov 16, 2020
ocket8888
approved these changes
Nov 17, 2020
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
Tests say it's working, and I can't see anything wrong with it.
ocket8888
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Use CentOS 8 for CDN-in-a-Box images by default * Use dnf instead of yum * If on CentOS 8, enable additional repositories before trying to install packages * Install python3 packages, not python36 * Specify additional packages to install that would have been automatically installed on CentOS 7 * Use Traffic Server built for CentOS 7 on CentOS 8 * Update for openssl 1.1: Open permissions on generated certs * We only need certs to be world-readable, not world-writable * Alpine Linux is not based on CentOS * Strip potential minor version from CENTOS_VERSION before using in repo RPM URL * Make Traffic Portal UI tests Dockerfile CentOS 8-compatible * More reliable way of deriving major version from CENTOS_VERSION that will work with CentOS 10 (cherry picked from commit a4a8700)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Depends on #5262 (merged), drafted until #5262 is closed.This PR bases the CDN in a Box Docker images off of CentOS 8 by default but allows users to continue to use CentOS 7 if they want by specifying the
CENTOS_VERSIONdocker-composebuild arg.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Build and run CDN in a Box normally, make sure it works.
export DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1 docker-compose build --parallel docker-compose down -v docker-compose upBuild and run CDN in a Box with CentOS 7 images, make sure it works.
export DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1 docker-compose build --parallel --build-arg CENTOS_VERSION=7 docker-compose down -v docker-compose upThe following criteria are ALL met by this PR