Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

GHA: Cache CPAN modules by OS version#5262

Merged
rawlinp merged 4 commits intoapache:masterfrom
zrhoffman:cached-cpan-centos-version
Nov 9, 2020
Merged

GHA: Cache CPAN modules by OS version#5262
rawlinp merged 4 commits intoapache:masterfrom
zrhoffman:cached-cpan-centos-version

Conversation

@zrhoffman
Copy link
Member

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

As a follow-up to #5253, this PR

  • adds CentOS version to the cache keys
  • Uses infrastructure/cdn-in-a-box/traffic_ops/local as the modules cache location
  • Removes copied-in modules and reruns carton if modules were copied in and carton failed

Caching modules by the version of the OS they were built on is necessary to avoid issues related to version differences in Perl and dynamically-linked libraries.

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Documentation
  • CI tests

What is the best way to verify this PR?

  • Run CDN in a Box, make sure it works
  • Using the instructions added to the Docs, copy the Perl lib out of the Traffic Ops Perl container while it is running, then rebuild the trafficops-perl image
    docker cp $(docker-compose ps -q trafficops-perl):/opt/traffic_ops/app/local traffic_ops
    and make sure you don't need to rebuild all of the modules again
  • Make sure the CDN-in-a-Box CI GHA workflow passes

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR updates tests
  • This PR includes documentation
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman zrhoffman added documentation related to documentation regression bug a bug in existing functionality introduced by a new version performance impacts/improves/measures performance automation related to automated testing/deployment/packaging etc. labels Nov 7, 2020
@zrhoffman zrhoffman assigned rawlinp and unassigned rawlinp Nov 9, 2020
@zrhoffman zrhoffman requested a review from rawlinp November 9, 2020 17:12
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caching worked as expected, CIAB came up fine.

@rawlinp rawlinp merged commit 61a0d8a into apache:master Nov 9, 2020
@zrhoffman zrhoffman deleted the cached-cpan-centos-version branch November 10, 2020 00:17
ocket8888 pushed a commit to ocket8888/trafficcontrol that referenced this pull request Nov 11, 2020
* Associate cached modules with major CentOS version

* Retry carton on failure after removing existing modules

* Use CDN in a Box-specific Perl modules cache

* Install Carton right after installing cpanminus

(cherry picked from commit 61a0d8a)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. documentation related to documentation performance impacts/improves/measures performance regression bug a bug in existing functionality introduced by a new version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants