This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Cleanup parent.config generation code#6618
Merged
rawlinp merged 1 commit intoapache:masterfrom May 11, 2022
Merged
Conversation
rob05c
added
tech debt
jpappa200
approved these changes
Apr 14, 2022
Contributor
jpappa200
left a comment
jpappa200
left a comment
There was a problem hiding this comment.
👍 LGTM generated config and config was unchanged.
Various techdebt cleanup of parent.config generation. Generated config should be byte-for-byte identical with or without this PR. - combines "profileCache" and "originServers" into a single "serversWithParams" variable, since the params apply to and are only ever useful with their corresponding server - renames "profileCache" struct to "parentServerParams", which is what it is, profileCache is an incredibly unmeaningful name inherited from ancient Perl code - removes unused parentConfigDS symbols - removes cgServer struct and replaces usage with real Servers; also inherited from ancient Perl code
rob05c
force-pushed
the
cleanup-parent-symbols
branch
from
cd68ae3 to
191695d
Compare
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
Various techdebt cleanup of parent.config generation. Generated config should be byte-for-byte identical with or without this PR. - combines "profileCache" and "originServers" into a single "serversWithParams" variable, since the params apply to and are only ever useful with their corresponding server - renames "profileCache" struct to "parentServerParams", which is what it is, profileCache is an incredibly unmeaningful name inherited from ancient Perl code - removes unused parentConfigDS symbols - removes cgServer struct and replaces usage with real Servers; also inherited from ancient Perl code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various techdebt cleanup of parent.config generation, inherited from ancient transliterated Perl.
Generated config should be byte-for-byte identical with or without this PR.
profileCacheandoriginServersinto a singleserversWithParamsvariable, since the params apply to and are only ever useful with their corresponding serverprofileCachestruct toparentServerParams, which is what it is, and matches the correspondingparentDSParams. TheprofileCachename was inherited from ancient Perl codeparentConfigDS*symbolscgServerstruct and replaces usage with real Servers; also inherited from ancient Perl codeWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run tests. Generate config, verify config is unchanged.
If this is a bugfix, which Traffic Control versions contained the bug?
Not a bug fix.
PR submission checklist
[x] This PR has teststests exist for all affected code[x] This PR has documentationno docs, no interface change[x] This PR has a CHANGELOG.md entryno interface change, no behavioral change