This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix t3c multiple profile generation #7163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob05c
added
bug
rob05c
force-pushed
the
fix-t3c-multiple-profile-generation
branch
3 times, most recently
from
11b858d to
835a7b5
Compare
zrhoffman
added
the
high impact
rob05c
force-pushed
the
fix-t3c-multiple-profile-generation
branch
3 times, most recently
from
2c052b3 to
0383804
Compare
Fixes a t3c bug resulting in only params from the last profile when multiple profiles are assigned. The bug was a go for loop overwriting the loop variable which was stored, required a copy of the iteration variable.
rob05c
force-pushed
the
fix-t3c-multiple-profile-generation
branch
from
0383804 to
a9b40ef
Compare
zrhoffman
added
low impact
Member
Author
|
I don't think this is really low-impact. It breaks config gen for all servers with multiple profiles assigned |
rob05c
added
high impact
traeak
approved these changes
Nov 4, 2022
Contributor
traeak
left a comment
traeak
left a comment
There was a problem hiding this comment.
This looks good. A proper fix.
ocket8888
approved these changes
Nov 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes t3c generation when servers have multiple profiles. The bug was a shared loop variable being overwritten in the TO request.
This is a 1-line fix, but it can't be unit tested because the bug was in the actual TO request, and the t3c Integration Tests are still on TO API v3 which doesn't have multiple Profiles. So testing this required updating the framework to v4, which is done in #7167 .
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run tests. Generate config on a server with multiple profiles, verify config is as-expected and all profiles have their parameters applied as-expected.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist
[ ] This PR has teststests can't be written until the t3c integration framework is upgraded to v3, which is a considerable amount of work[ ] This PR has documentationno docs, no interface change