This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix t3c test duplication and upgrade to v4 #7167
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the TO test setup to a shared library to remove duplication in the ORT/t3c integration tests, because that was easier than upgrading t3c tests to API v4, which was necessary to test multiple profiles.
It turned out, moving the TO test data setup to a library was easier than fixing all the changes in v4.
It's a lot of lines changes (3k duplicate lines removed), but there's no logic change in the tests, just moving and renaming things. More conveniences could be added, like moving the WithObjs helpers to the library and removing the wrappers. But it seemed better to keep this as small as possible; it's already huge.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run tests.
If this is a bugfix, which Traffic Control versions contained the bug?
Not a bug fix.
PR submission checklist
[x] This PR has documentationno docs, no interface change[x] This PR has a CHANGELOG.md entryno changelog, no user interface change