Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Mar 1, 2023

This PR fixes #4380 and fixes #6304 by updating the ATC module path from

module github.com/apache/trafficcontrol

to

module github.com/apache/trafficcontrol/v7

and updates references to the latest ATC Go module around the repo to reference the v7 version. See the git history for the commands used to update files and #4380 (comment) for the motivation for this PR.

Note that this PR does not move any files.

Once this PR is merged, a message will appear at the top of https://pkg.go.dev/github.com/apache/trafficcontrol lik this:

Deprecation notice

because the latest module will be at https://pkg.go.dev/github.com/apache/trafficcontrol/v7.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Cache Config (T3C, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Stats
  • Grove
  • CDN in a Box (Enroller)

What is the best way to verify this PR?

Verify that the 8 non-URL, non-local-path instances of github.com/apache/trafficcontrol/ in the repo that did not have v7/ appended to them. They should stay as-is:

repo=github.com/apache/trafficcontrol/
git ls-files | xargs grep -Fn "$repo" 2>/dev/null | grep -vE "(https://|src/)${repo//./\\.}" | grep -vF "${repo}v7"
blueprints/api.guidelines.md:101:[the ATC library's Alert structure](https://pkg.go.dev/github.com/apache/trafficcontrol/lib/go-tc#Alert).
blueprints/refetch-invalidation.md:291:github.com/apache/trafficcontrol/lib/go-atscfg/regexrevalidatedotconfig_test.go
blueprints/refetch-invalidation.md:298:github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/invalidationjobs/invalidationjobs.go
blueprints/refetch-invalidation.md:304:github.com/apache/trafficcontrol/traffic_ops/testing/api/v1/jobs_test.go
blueprints/refetch-invalidation.md:305:github.com/apache/trafficcontrol/traffic_ops/testing/api/v2/jobs_test.go
blueprints/refetch-invalidation.md:306:github.com/apache/trafficcontrol/traffic_ops/testing/api/v3/jobs_test.go
blueprints/refetch-invalidation.md:307:github.com/apache/trafficcontrol/traffic_ops/testing/api/v4/jobs_test.go
CHANGELOG.md:694:- Importing Traffic Ops Go clients via the un-versioned `github.com/apache/trafficcontrol/traffic_ops/client` is now deprecated in favor of versioned import paths e.g. `github.com/apache/trafficcontrol/traffic_ops/v3-client`.

PR submission checklist

git ls-files |
  grep -vE '^CHANGELOG|^vendor|\.go$' |
  xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' |
  xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v7/|g'
git ls-files '**.go' |
  grep -vE ^vendor |
  xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' |
  xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v7/|g'
@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops Traffic Stats related to Traffic Stats Traffic Monitor related to Traffic Monitor documentation related to documentation grove related to the "grove" HTTP caching server implementation tech debt rework due to choosing easy/limited solution cdn-in-a-box related to the Docker-based CDN-in-a-Box system tools related to tools outside of main components, e.g. 'compare' cache-config Cache config generation TO Client (Go) related to the Go implementation of a TC client tc-health-client Traffic Control Health Client labels Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #7374 (f5061d8) into master (a6b2954) will decrease coverage by 0.02%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7374      +/-   ##
============================================
- Coverage     65.64%   65.62%   -0.02%     
  Complexity       98       98              
============================================
  Files           323      323              
  Lines         12827    12825       -2     
  Branches        965      965              
============================================
- Hits           8420     8417       -3     
  Misses         4048     4048              
- Partials        359      360       +1     
Flag Coverage Δ
traffic_ops_integration 69.42% <ø> (ø)
traffic_portal_v2 74.34% <ø> (-0.06%) ⬇️
unit_tests 74.34% <ø> (-0.06%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-generate/cfgfile/all.go 62.06% <ø> (ø)
cache-config/t3c-generate/cfgfile/routing.go 84.00% <ø> (ø)
cache-config/t3c-generate/cfgfile/sslkeys.go 0.00% <ø> (ø)
cache-config/t3c-generate/cfgfile/wrappers.go 49.36% <ø> (ø)
cache-config/t3c-generate/config/config.go 0.89% <ø> (ø)
cache-config/t3c-generate/plugin/hello_world.go 9.52% <ø> (ø)
cache-config/t3c-generate/plugin/plugin.go 67.44% <ø> (ø)
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
.../t3c-generate/update-to-client/update-to-client.go 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman
Copy link
Member Author

Closing in favor of #7814

@zrhoffman zrhoffman closed this Sep 22, 2023
@zrhoffman zrhoffman deleted the module-v7 branch September 22, 2023 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache-config Cache config generation cdn-in-a-box related to the Docker-based CDN-in-a-Box system documentation related to documentation grove related to the "grove" HTTP caching server implementation tc-health-client Traffic Control Health Client tech debt rework due to choosing easy/limited solution TO Client (Go) related to the Go implementation of a TC client tools related to tools outside of main components, e.g. 'compare' Traffic Monitor related to Traffic Monitor Traffic Ops related to Traffic Ops Traffic Stats related to Traffic Stats

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users cannot import the TO API 4.0 client getting newer versions to appear on pkg.go.dev

1 participant