Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 8, 2023

Bumps socket.io-parser from 4.2.2 to 4.2.4.

Release notes

Sourced from socket.io-parser's releases.

4.2.3

⚠️ This release contains an important security fix ⚠️

A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js process:

TypeError: Cannot convert object to primitive value
       at Socket.emit (node:events:507:25)
       at .../node_modules/socket.io/lib/socket.js:531:14

Please upgrade as soon as possible.

Bug Fixes

  • check the format of the event name (3b78117)

Links

Changelog

Sourced from socket.io-parser's changelog.

4.2.4 (2023-05-31)

Bug Fixes

  • ensure reserved events cannot be used as event names (d9db473)
  • properly detect plain objects (b0e6400)

3.4.3 (2023-05-22)

Bug Fixes

  • check the format of the event name (2dc3c92)

4.2.3 (2023-05-22)

Bug Fixes

  • check the format of the event name (3b78117)
Commits
  • 164ba2a chore(release): 4.2.4
  • b0e6400 fix: properly detect plain objects
  • d9db473 fix: ensure reserved events cannot be used as event names
  • 6a5a004 docs(changelog): include changelog for release 3.4.3
  • b6c824f chore(release): 4.2.3
  • dcc70d9 refactor: export typescript declarations for the commonjs build
  • 3b78117 fix: check the format of the event name
  • 0841bd5 chore: bump ua-parser-js from 1.0.32 to 1.0.33 (#121)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update JavaScript or JavaScript-related code labels Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #7569 (9d4c494) into master (890f3b4) will increase coverage by 3.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7569      +/-   ##
============================================
+ Coverage     28.80%   32.16%   +3.35%     
  Complexity       98       98              
============================================
  Files           598      691      +93     
  Lines         77013    80879    +3866     
  Branches         90      965     +875     
============================================
+ Hits          22185    26016    +3831     
+ Misses        52740    52725      -15     
- Partials       2088     2138      +50     
Flag Coverage Δ
golib_unit 53.64% <ø> (+<0.01%) ⬆️
grove_unit ?
t3c_unit 5.96% <ø> (ø)
traffic_monitor_unit 26.44% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.50% <ø> (+0.04%) ⬆️
traffic_portal_v2 74.39% <ø> (?)
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 29.45% <ø> (+3.84%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 143 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamrickus
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/experimental/traffic-portal/socket.io-parser-4.2.4 branch from 4e83bca to 4bb9b04 Compare July 11, 2023 15:17
@shamrickus
Copy link
Member

@dependabot rebase

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.2 to 4.2.4.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.2.2...4.2.4)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/experimental/traffic-portal/socket.io-parser-4.2.4 branch from 4bb9b04 to 9d4c494 Compare September 11, 2023 17:05
@shamrickus shamrickus merged commit be64c87 into master Sep 11, 2023
@shamrickus shamrickus deleted the dependabot/npm_and_yarn/experimental/traffic-portal/socket.io-parser-4.2.4 branch September 11, 2023 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update JavaScript or JavaScript-related code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant