uri_signing plugin: Fix missing payload validation for the iss field.#8901
Merged
traeak merged 1 commit intoapache:masterfrom Jun 14, 2022
Merged
Conversation
Contributor
Author
|
@dsouza93 you may be interested in this. |
|
I am taking a look at this today @brbzull0! Thanks a ton for posting this up. It may take me just a little more time. I have a bunch of fixes for this plugin that are in our internal repos that I though I pushed to the open source repo here. I want to just go through them and ensure that this is not one of those and that I didn't miss anything else. That being said, I'll definitely get around to testing this and approving by Wednesday next week! Also thank you so much for adding that unit test as well! 🙏 |
ezelkow1
approved these changes
Jun 14, 2022
Member
ezelkow1
left a comment
ezelkow1
left a comment
There was a problem hiding this comment.
lgtm (and I trust Dylan's review :) )
dsouza93
pushed a commit
to dsouza93/trafficserver
that referenced
this pull request
Jun 14, 2022
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Modifying array outside bounds (apache#8806) Add escape json for logging (apache#8886) Removes remaining vestiges to the backdoor port (apache#8793) Add Au test for prefetch plugin in simple mode. (apache#8810) uri_signing plugin: Fix missing payload validation for the iss field. (apache#8901) Cleanup SNIConfig (apache#8892) Fix autest uses of File exists parameter (apache#8906) Do not modify Transfer-Encoding header on retry (apache#8899) Fix plugin stats_over_http OK reason phrase (apache#8902) Add AuTest for stats-over-http plugin (apache#8422)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the crash for #8874
Also adding some error messages that would eventually help for debugging.