Fix autest uses of File exists parameter#8906
Merged
bneradt merged 1 commit intoapache:masterfrom Jun 13, 2022
Merged
Conversation
The AuTest File exists parameter can be configured in one of three ways: 1. If True, then AuTest will fail unless the file exists. 2. If False, then AuTest will fail unless the file does not exist. 3. If None (the default) then no existence check is done. Many of our tests configured exists=False assuming it would behave like the default None configuration above. That is, they used exists=False to turn off verification. That is in fact how AuTest has behaved until now, but that is a bug in the AuTest framework. The next release of AuTest will have a fix such that exists=False will now verify that a file does not in fact exist which will cause some of our tests to fail. This patch anticipates that fix to AuTest and fixes our use of exists accordingly.
randall
approved these changes
Jun 13, 2022
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jun 15, 2022
The AuTest File exists parameter can be configured in one of three ways: 1. If True, then AuTest will fail unless the file exists. 2. If False, then AuTest will fail unless the file does not exist. 3. If None (the default) then no existence check is done. Many of our tests configured exists=False assuming it would behave like the default None configuration above. That is, they used exists=False to turn off verification. That is in fact how AuTest has behaved until now, but that is a bug in the AuTest framework. The next release of AuTest will have a fix such that exists=False will now verify that a file does not in fact exist which will cause some of our tests to fail. This patch anticipates that fix to AuTest and fixes our use of exists accordingly.
zwoop
pushed a commit
that referenced
this pull request
Jun 15, 2022
The AuTest File exists parameter can be configured in one of three ways: 1. If True, then AuTest will fail unless the file exists. 2. If False, then AuTest will fail unless the file does not exist. 3. If None (the default) then no existence check is done. Many of our tests configured exists=False assuming it would behave like the default None configuration above. That is, they used exists=False to turn off verification. That is in fact how AuTest has behaved until now, but that is a bug in the AuTest framework. The next release of AuTest will have a fix such that exists=False will now verify that a file does not in fact exist which will cause some of our tests to fail. This patch anticipates that fix to AuTest and fixes our use of exists accordingly. (cherry picked from commit 9d13a8d)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog Modifying array outside bounds (apache#8806) Add escape json for logging (apache#8886) Removes remaining vestiges to the backdoor port (apache#8793) Add Au test for prefetch plugin in simple mode. (apache#8810) uri_signing plugin: Fix missing payload validation for the iss field. (apache#8901) Cleanup SNIConfig (apache#8892) Fix autest uses of File exists parameter (apache#8906) Do not modify Transfer-Encoding header on retry (apache#8899) Fix plugin stats_over_http OK reason phrase (apache#8902) Add AuTest for stats-over-http plugin (apache#8422)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AuTest File exists parameter can be configured in one of three ways:
Many of our tests configured exists=False assuming it would behave like
the default None configuration above. That is, they used exists=False to
turn off verification. That is in fact how AuTest has behaved until now,
but that is a bug in the AuTest framework. The next release of AuTest
will have a fix such that exists=False will now verify that a file does
not in fact exist which will cause some of our tests to fail. This patch
anticipates that fix to AuTest and fixes our use of exists accordingly.