Skip to content

fix(cli): reduce traceback length by disabling Typer pretty exceptions - #704

Merged
luisremis merged 13 commits into
developfrom
fix/issue-467
May 24, 2026
Merged

fix(cli): reduce traceback length by disabling Typer pretty exceptions#704
luisremis merged 13 commits into
developfrom
fix/issue-467

Conversation

@ad-claw000

Copy link
Copy Markdown
Contributor

Summary

  • Disabled pretty_exceptions_enable on Typer apps across the CLI commands to revert to standard Python tracebacks.
  • This addresses the issue where the rich error stack traces were excessively long and mistaken for IPython causing slowdowns.

Verification

  • Verified that a deliberate exception raised inside a Typer command produces a standard Python traceback instead of a rich Typer stack trace.
  • Checked adb config ls command execution still behaves correctly.

Fixes #467.

Copilot AI review requested due to automatic review settings May 20, 2026 00:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the adb Typer-based CLI to disable Typer’s Rich “pretty exceptions” so errors fall back to standard Python tracebacks, reducing excessively long stack traces and avoiding the Rich/IPython-related slowdown described in #467.

Changes:

  • Disabled Typer pretty exceptions (pretty_exceptions_enable=False) for the top-level adb app and all CLI sub-apps.
  • Kept existing exception-local settings (pretty_exceptions_show_locals=False) while fully disabling pretty exception rendering.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
aperturedb/cli/utilities.py Disable Typer pretty exceptions for the utils command group app.
aperturedb/cli/transact.py Disable Typer pretty exceptions for the transact command group app.
aperturedb/cli/tokens.py Disable Typer pretty exceptions for the tokens command group app.
aperturedb/cli/keys.py Disable Typer pretty exceptions for the keys command group app.
aperturedb/cli/ingest.py Disable Typer pretty exceptions for the ingest command group app.
aperturedb/cli/configure.py Disable Typer pretty exceptions for the config command group app.
aperturedb/cli/adb.py Disable Typer pretty exceptions for the top-level adb CLI app.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ad-claw000 ad-claw000 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied autopep8 formatting to the new log messages to fix the pre-commit CI failure.

@ad-claw000 ad-claw000 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the pre-commit CI failure by applying autopep8 formatting to the new log messages. Ready for review!

Copilot AI review requested due to automatic review settings May 23, 2026 04:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@luisremis
luisremis merged commit d26470d into develop May 24, 2026
2 checks passed
@luisremis
luisremis deleted the fix/issue-467 branch May 24, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK trial on Mac

3 participants