mainline: bump to 7.2-rc2#10150
Conversation
📝 WalkthroughWalkthroughUpdates the mainline kernel version target from 7.2-rc1 to 7.2-rc2, and modifies several archived meson64-7.2/rockchip64-7.2 kernel patches: spidev compatible IDs, PCIe MPS configuration, RG-DS USB OTG wiring, ES8316 NULL-check fix, HDMI/VOP clock and register tables, RK3308 VOP support, and Panthor GPU bus-clock handling. ChangesMainline Kernel Version Selection
Estimated code review effort: 2 (Simple) | ~10 minutes Archived Kernel Patch Updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
patch/kernel/archive/rockchip64-7.2/general-hdmi-clock-fixes.patch (1)
188-190: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winRemove the duplicated
dw_hdmi_set_high_tmds_clock_ratio()call.
dw_hdmi_set_high_tmds_clock_ratio(dw_hdmi, display)is called twice indw_hdmi_rockchip_genphy_init(). Drop the second call.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@patch/kernel/archive/rockchip64-7.2/general-hdmi-clock-fixes.patch` around lines 188 - 190, Remove the duplicated dw_hdmi_set_high_tmds_clock_ratio() invocation in dw_hdmi_rockchip_genphy_init() so the helper is only called once; keep the existing call and delete the extra repeated line in the HDMI PHY init flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@patch/kernel/archive/rockchip64-7.2/general-hdmi-clock-fixes.patch`:
- Around line 188-190: Remove the duplicated dw_hdmi_set_high_tmds_clock_ratio()
invocation in dw_hdmi_rockchip_genphy_init() so the helper is only called once;
keep the existing call and delete the extra repeated line in the HDMI PHY init
flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9d6ea493-01fc-4146-be83-7a7e54ca8300
📒 Files selected for processing (11)
config/sources/mainline-kernel.conf.shpatch/kernel/archive/meson64-7.2/drv-spi-spidev-remove-warnings.patchpatch/kernel/archive/meson64-7.2/general-gpio-shared-cansleep-0001-gpio-shared-proxy-always-mutex.patchpatch/kernel/archive/meson64-7.2/general-gpio-shared-cansleep-0002-pinctrl-meson-restore-non-sleeping-gpio.patchpatch/kernel/archive/meson64-7.2/x-PATCH-v7-2-2-PCI-dwc-Remove-redundant-MPS-configuration.patchpatch/kernel/archive/rockchip64-7.2/board-rgds-04-usb-otg-dual-role.patchpatch/kernel/archive/rockchip64-7.2/drv-spi-spidev-remove-warnings.patchpatch/kernel/archive/rockchip64-7.2/general-fix-es8316-kernel-panic.patchpatch/kernel/archive/rockchip64-7.2/general-hdmi-clock-fixes.patchpatch/kernel/archive/rockchip64-7.2/rk3308-vop-output.patchpatch/kernel/archive/rockchip64-7.2/rk35xx-panthor-1GHz.patch
💤 Files with no reviewable changes (2)
- patch/kernel/archive/meson64-7.2/general-gpio-shared-cansleep-0002-pinctrl-meson-restore-non-sleeping-gpio.patch
- patch/kernel/archive/meson64-7.2/general-gpio-shared-cansleep-0001-gpio-shared-proxy-always-mutex.patch
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes