rockchip64: RG Vita Pro drivers - address CodeRabbit review comments from #10321

[crackerjacques]

Follow-up to #10321: addresses the CodeRabbit findings on the Anbernic RG Vita Pro
driver patches that were left unaddressed at merge. Four independent, low-risk
fixes, each applied to both rockchip64-7.1 and rockchip64-7.2:

• rocknix generic-dsi panel — honor the configured ready delay. load_globals()
  parsed ctx->delays.ready but the msleep() using it was commented out, so the
  panel-description ready delay was ignored.
• spi-mcu-joypad — depends on LEDS_CLASS_MULTICOLOR. The driver calls
  devm_led_classdev_multicolor_register() unconditionally, but the old
  depends on LEDS_CLASS_MULTICOLOR || LEDS_CLASS_MULTICOLOR=n allowed building it
  with the multicolor LED class disabled, which fails to link.
• sgm41542 — return PTR_ERR(sgm->charger) instead of -EINVAL on
  IS_ERR(), so -EPROBE_DEFER from devm_power_supply_register() is preserved.
• cw221x — fix the dead zero-assignment on the firmware-mismatch path: the error
  branch set cw_bat->cw_current = 0 but a later unconditional
  cw_bat->cw_current = cw_current overwrote it with the stale unscaled value, so the
  reported current was never actually zeroed.

The remaining CodeRabbit comments on these drivers are either intentional
(rmi4 -EPROBE_DEFER for the TDDI touch IC startup) or hardware limitations
(the MCU exposes a single global LED brightness level, not per-ring), so they are
left as-is.

Testing

Built rockchip64 edge (7.1) and bleedingedge (7.2-rc6).

Summary by CodeRabbit

• New Features
  • Added support for configurable generic MIPI-DSI display panels, including display modes, orientation, backlight, power sequencing, and initialization.
  • Added SPI MCU joypad support with analog controls and multicolor RGB LED functionality.
  • Added battery monitoring for CW2215/CW2217/CW2218 fuel gauges, including capacity, temperature, current, cycle count, and health reporting.
  • Added SGM41542 single-cell charger support with charging controls, battery status, fault reporting, and USB OTG power output.

[coderabbitai]

📝 Walkthrough

Walkthrough

The patch set updates Rockchip64 7.1 and 7.2 kernel support. It enables the panel ready delay, integrates the SPI MCU joypad, corrects CW221x fallback current handling, and propagates SGM41542 registration errors.

Changes

Rockchip64 driver updates

Layer / File(s)	Summary
Panel ready-delay handling patch/kernel/archive/rockchip64-7.1/general-drm-panel-add-rocknix-generic-dsi.patch, patch/kernel/archive/rockchip64-7.2/general-drm-panel-add-rocknix-generic-dsi.patch	The panel preparation sequence now applies the configured ready delay before marking the panel prepared.
SPI MCU joypad integration patch/kernel/archive/rockchip64-7.1/general-input-add-spi-mcu-joypad-01-options.patch, patch/kernel/archive/rockchip64-7.2/general-input-add-spi-mcu-joypad-01-options.patch	The joystick configuration requires multicolor LED support and the 7.2 patch adds Kconfig and Makefile wiring for the driver components.
CW221x current fallback patch/kernel/archive/rockchip64-7.1/general-power-supply-add-cw221x.patch, patch/kernel/archive/rockchip64-7.2/general-power-supply-add-cw221x.patch	Unsupported firmware detection now produces a zero current value through the common state assignment.
SGM41542 error propagation patch/kernel/archive/rockchip64-7.1/general-power-supply-add-sgm41542.patch, patch/kernel/archive/rockchip64-7.2/general-power-supply-add-sgm41542.patch	Power-supply registration failures now return the underlying PTR_ERR value instead of -EINVAL.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• armbian/build#10140: Related MIPI-DSI DRM panel integration changes.
• armbian/build#10150: Related Rockchip64 7.2 patch-set updates.
• armbian/build#10321: Related Rockchip64 7.2 patch updates involving the same driver patches.

Suggested labels: BSP, Framework

Suggested reviewers: igorpecovnik, rpardini, iav

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the rockchip64 RG Vita Pro driver fixes and their purpose as follow-up CodeRabbit review changes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!