fix: wave-5 readiness — AIF Handoff overlap analysis + scope annotations (SSOT #27-#29) - #31
Merged
Merged
Conversation
Prior-art: skipped — research patch documenting prior-art evidence; no new capability artifact, no new packages/ subdirectory.
…SE (matrix completion + cell-level clarifications) MAJOR-1: added S3+C2 rows to §3 matrix (now 7×7, 49 cells, 0 blank); S3×P3=ORT (different enforcement layers: AIF runtime file-path vs git-level audit trail); C2×P5=OVL(ours) (session-topology constraint parallel). MAJOR-2: chose variant A — downgraded C1×P4 OVL→ORT; rationale: same mode-fork lexeme, different problem classes (external-system integration suppression vs model-quota+context-isolation) per #pattern-matching-on-name. MINOR-1: §13.25/§13.22 cross-refs added to §8; #TBD-A and #TBD-B «Trigger to revisit» extended with «OR Wave 5 §13.25 implementation surfaces these MCPs as discoverable candidates». MINOR-2: §4 row A1 executable-check expanded with exact exit-code-1 grep command + stderr message; backward-sweep prerequisite (~24 patches) added; §6 #TBD-C trigger replaced with «Stage 3 backward-sweep prerequisite: aif-handoff-A1-annotation adoption requires sweep of all existing research-patches atomically with CI gate». MINOR-3: §4 row C1 trigger quantified: «≥2 reviewer-reported file-prompt session-loss incidents in one quarter logged under #mode-b-fragility; OR orchestrator session lifecycle docs upgrade explicitly describes Mode B failure mode»; same in §6 #TBD-A. MINOR-4: A1×P6 cell rationale corrected — AIF runtime-only enforcement in HANDOFF_MODE=1 vs our git-level pre-push+principle+trailer; winner=ours for auditable-trail, AIF wins for runtime API contract. MINOR-5: S1×P2 recategorized INV→ORT; removed INV rationale (granularity + problem differences: file-level vs record-level, context transfer vs state sync). Prior-art: skipped — editorial revision to research patch addressing Stage 2 reviewer findings; no new capability, no new packages/ subdirectory.
…verlap analysis Adds three entries from the aif-handoff-overlap-analysis mandate (Stage 3, Phase A). Entries reflect verdicts from Stage 1 research + Stage 2 review: - #27 DEFER: AIF Handoff HANDOFF_MODE env-var fork (C1×P4 ORT — different problem classes; DEFER pending non-interactive orchestration pipeline) - #28 DEFER: AIF Handoff paused:true/false semantic (S1×P5 ORT — different granularities; DEFER pending wave state machine formalisation Phase 11+) - #29 ADAPT: AIF first-line plan annotation pattern (A1×P6 OVL; ADAPT as <!-- scope:§N --> for research patches + automated trigger sweeps §1.6) Phase B (ADAPT implementation: annotations + CI gate) follows in separate commit, citing entry #29 as Prior-art trailer. Prior-art: skipped — adding SSOT entries to prior-art-evaluations.md; no new capability artifact, no new file under packages/, no new package.json dep.
…-> (SSOT #29) Implements ADAPT verdict from aif-handoff-overlap-analysis mandate (Stage 3). Adapts AIF handoff:task first-line plan annotation pattern (SSOT #29) for research patches as <!-- scope:<slug> --> machine-parseable first-line marker. Changes: - 20 research patches: added <!-- scope:<slug> --> as first line per canonical mapping (§13.21, §13.23, §13.25, wave-7, phase-8.8, methodology, aif-handoff-mandate) - packages/core/principles/10-research-patch-annotation.test.ts: companion principle test with anti-tautology mutation check (Vitest, 5 tests green) - .github/workflows/audit-self.yml: CI gate verifying annotation presence on all research patches (except README.md), added to mechanical job - 2026-05-10-wave-6-review-verdicts.md, 2026-05-10-wave-7-review-verdicts.md: fix pre-existing MD040 bare fences (language=text) uncovered by pre-commit hook Enables automated §1.6 trigger sweep: grep "scope:§13.X" across patches instead of prose-level pattern matching on filenames. §1.7 backward check: all 20 existing patches annotated atomically with CI gate in this commit (complete sweep, not §1.5 floor). Prior-art: prior-art-evaluations.md#29 (AIF handoff:task first-line plan annotation ADAPT — <!-- scope:slug --> for research patches, automated §1.6 sweep support, verdict ADAPT 2026-05-11).
artyhoo
added a commit
that referenced
this pull request
May 11, 2026
…32 → #31-#36 (AIF Handoff collision fix) 2026-05-11 readiness review on `fix/wave-5-readiness-revise` identified BLOCKER B-1: the branch's own AIF Handoff overlap analysis (commits `5d8cf1c`, `0f7f572`) landed SSOT entries #27-#30 in `prior-art-evaluations.md` for HANDOFF_MODE / paused-semantic / handoff:task / implement-coordinator — re-occupying the range previously remap'd to in `d7a6c87` for Wave 5 §13.25 candidates. Remap §10 table + all cross-references in §4 (Continue permissions SSOT ref), §10 narrative (Next ID / entries #1-#N), §12 Implementation outline, §13.1 Forward-check anti-pattern row, See also block. Added explicit §10 footnote logging the second remap for future readers. Mapping: 27 AIF /aif → 31 28 AIF skills.sh → 32 29 Continue permissions → 33 30 Cline marketplace → 34 31 Codex MCP CLI → 35 32 Roo Code installer → 36 Operator-side kickoff (`.claude/orchestrator-prompts/wave-5-tool-bootstrapping/orchestrator-kickoff.md`, gitignored) updated in lockstep: m2 Windsurf ID #33 → #37 (next-free after new range); SCOPE block acknowledges «#27-#30 AIF Handoff occupied»; ATTN STOP rule baseline updated to existing entries #1-#30. Closes readiness-review M-1 (research §10 not yet edited for the new collision) and addresses root cause of BLOCKER B-1. Push + CI-green on HEAD is the remaining operator action before B-1 is fully closed. Non-touched: existing SSOT entries #1-#30 (Wave 7 #16-#26 + AIF Handoff #27-#30); AIF /aif row's «entry #8 cadence» reference unchanged. Doc errata only — not a capability commit per CLAUDE.md gate; not a §1.7 rule extension. Prior-art: skipped — doc errata only (second SSOT-ID remap parallel to d7a6c87 precedent), no new capability per CLAUDE.md gate; resolves readiness-review BLOCKER B-1 + MAJOR M-1 (2026-05-11) on `fix/wave-5-readiness-revise` umbrella.
Merged
4 tasks
8 tasks
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prior-art-evaluations.md(DEFER×2 + ADAPT×1 for AIF Handoff primitives).packages/core/principles/10-research-patch-annotation.test.ts) — enforces<!-- scope:<slug> -->first-line annotation on all research patches; 85 lines, 3 anti-tautology mutation checks.audit-self.yml→ «Research patch scope annotations» step — blocks merge if any patch missing annotation.§13.21,§13.23,§13.25,wave-7,phase-8.8,methodology,aif-handoff-mandate).open-questions.md: research GO, implementation pending (Wave 5).Test plan
make self-audit→ 56 tests green (10 principle files incl. new docs: Phase 8.8 session prompt (replaces C-parked PR #9) #10)Research patch scope annotationsstep green (all 20 patches annotated)No file > 500 linesgreen (§13.23 = 499, §13.25 = 487 post-annotation)grep -L "^<!-- scope:" docs/meta-factory/research-patches/*.md | grep -v README→ empty§1.7 Forward-check applied
Checked all active discipline layers for the new
<!-- scope:<slug> -->annotation rule (principle 10 + CI gate):packages/→ capability commit →Prior-art: prior-art-evaluations.md#29trailer present in commitd7272c6✅handoff:taskfirst-line annotation pattern; commit cites it ✅open-questions.md✅README.mdin the folder carries the authority header; individual patch files inherit, no per-file Authoritative-for required ✅5d8cf1c(Phase A), cited positively in capability commitd7272c6(Phase B) — ID present before citing commit ✅§1.7 Backward-check applied
New rule scope: every
docs/meta-factory/research-patches/*.md(exceptREADME.md) must have<!-- scope:<slug> -->as first line.Complete sweep (not §1.5 floor): all 20 existing patch files enumerated from directory listing and annotated atomically in commit
d7272c6. Zero exemptions. Verification:grep -L "^<!-- scope:" docs/meta-factory/research-patches/*.md | grep -v README→ empty ✅audit-self.ymlenforces the invariant on all future patches ✅README.mdexclusion explicit in both CI gate and principle test ✅2026-05-12 retroactive Wave 8.5 note: This PR's §1.7 Forward-check section would not pass the Wave 8.1 substance gate (no file:line citations present). Pre-Wave-8 acceptance — kept as historical evidence of the
#discipline-theatregap that motivated §13.29.