Pin three accepted proposals that are already implemented (#246, #214, #185) - #806
Merged
Merged
Conversation
…#185) Each of these asks for behaviour the library already has, and each is pinned by the example the proposal itself gives, so that closing it rests on a test rather than on a reading. #246 a logarithmic solver, converting logarithms to a polynomial where possible log(2, x) + log(2, x - 1) = 1 -> { 2 } ln(x)^2 - 3*ln(x) + 2 = 0 -> { e, e^2 } #214 a ^ f(x) + b ^ g(x) + ... = 0 2^x + 4^x = 6 -> { 1 } 3^(2x) - 4*3^x + 3 = 0 -> { 0, 1 } #185 collecting unlike terms by treating each as an unknown e^x + sin(x) + 2e^x + 2sin(x) -> 3*(sin(x) + e^x) Every root is substituted back into its equation. A solver that answers the right root alongside a wrong one is not solving the equation, and the printed set does not say which it has done -- which is the whole reason #115 and #272 were defects rather than gaps. Grouped into one commit rather than three, against the usual habit of a branch per issue, because there is no behaviour change to bisect: it is one test file recording a measurement about three issues. Test-only; 8 pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246, #214 and #185 — each asks for behaviour the library already has.
Each is pinned by the example the proposal itself gives, so that closing it rests on a test rather than on my reading of it.
log(2, x) + log(2, x - 1) = 1→{ 2 };ln(x)^2 - 3ln(x) + 2 = 0→{ e, e^2 }a^f(x) + b^g(x) + ... = 0solvable2^x + 4^x = 6→{ 1 };3^(2x) - 4·3^x + 3 = 0→{ 0, 1 }e^x + sin(x) + 2e^x + 2sin(x)→3(sin(x) + e^x)Every root is substituted back into its equation. A solver that answers the right root alongside a wrong one is not solving it, and the printed set does not say which it has done — that distinction is what made #115 and #272 defects rather than gaps.
Grouped into one commit rather than three, against the usual habit of a branch per issue, because there is no behaviour change to bisect: it is one test file recording a measurement about three issues. Happy to split it if you would rather.
Test-only. 8 pass.
🤖 Generated with Claude Code