Visual improvements in WCSAxes #7961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding is determined for tick labels (including taking into account whether the ticks are facing in or out)
|
Hi there @astrofrog 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
lpsinger
approved these changes
Oct 24, 2018
astrofrog
added
the
zzz 💤 merge-when-ci-passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcParams and styles
This adds support for enough rcParams that styles now look reasonable:
Before (I'll just show once since you'll get the idea)
After
Tick label placement
Since ticks now face outwards by default, we need to be smarter about how we place the tick labels:
Before
After
Other changes
Since I had to regenerate all reference images, I've removed the custom filenames, going instead with the pytest-mpl default, and I've ensured that we always use the default initial style.
Fixes #7485