Skip to content

docs: documentation on how to skip chromium installation - #144

Merged
derberg merged 2 commits into
asyncapi:masterfrom
stavalfi:stav/improve-doc
Feb 9, 2021
Merged

docs: documentation on how to skip chromium installation#144
derberg merged 2 commits into
asyncapi:masterfrom
stavalfi:stav/improve-doc

Conversation

@stavalfi

@stavalfi stavalfi commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

according to a suggestion in asyncapi/generator#480 (comment)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Comment thread README.md Outdated
@derberg

derberg commented Feb 9, 2021

Copy link
Copy Markdown
Member

@stavalfi thanks a lot for such a fast PR. Just one comment added

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Feb 9, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
derberg merged commit 9f5904c into asyncapi:master Feb 9, 2021
@asyncapi-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants