This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Delay package deactivation until pending saves complete#83
Merged
smashwilson merged 13 commits intomasterfrom Sep 25, 2017
Merged
Delay package deactivation until pending saves complete#83smashwilson merged 13 commits intomasterfrom
smashwilson merged 13 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return a Promise from
.deactivate()that resolves when all saves currently in progress complete, successfully or otherwise.Depends on atom/atom#15740 and atom/atom#15554 for async deactivate support in core, so this won't work until Atom >= v1.21.0-beta0, and I'll need to make sure the specs are still green on stable and beta somehow 👀
Fixes #67.