New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay package deactivation until pending saves complete #83

Merged
merged 13 commits into from Sep 25, 2017

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Sep 25, 2017

Return a Promise from .deactivate() that resolves when all saves currently in progress complete, successfully or otherwise.

Depends on atom/atom#15740 and atom/atom#15554 for async deactivate support in core, so this won't work until Atom >= v1.21.0-beta0, and I'll need to make sure the specs are still green on stable and beta somehow 馃憖

Fixes #67.

smashwilson added some commits Sep 25, 2017

@smashwilson smashwilson merged commit 966ce86 into master Sep 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw-async-deactivate branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment