Skip to content

Emphasize landscape embed + fix external-link icon wrap#45

Merged
polter-dev merged 7 commits into
mainfrom
polish/embed-emphasis-linkicon
Jul 12, 2026
Merged

Emphasize landscape embed + fix external-link icon wrap#45
polter-dev merged 7 commits into
mainfrom
polish/embed-emphasis-linkicon

Conversation

@polter-dev

Copy link
Copy Markdown
Collaborator

Summary

  • widen only desktop landscape result rails from 300px to 400px, preserving the existing 300px vertical and mobile layouts
  • tighten landscape-only source metadata and desktop actions so the 16:9 embed is the focal point
  • keep every external-link icon attached to the final visible character while preserving overflow-wrap: anywhere for long URLs
  • cover landscape/vertical dimensions, mobile safeguards, safe external-link behavior, and actual wrapped-glyph/icon alignment

Root cause

The result grid used a fixed 300px rail regardless of source orientation. External-link labels also allowed a break at the text/icon seam, while the SVG reset left the Lucide icon block-level.

TDD evidence

  • orientation test first failed because the result grid had no data-embed attribute
  • desktop browser test first failed with a 300px landscape rail
  • external-link seam test first failed without a no-break trailing unit, then exposed the block-level SVG in the rendered layout

Validation

  • npm run lint
  • npm run typecheck
  • npm run test:unit — 226 passed, 5 skipped
  • npm run test:e2e — 34 passed, 2 expected skips
  • npm run build

Stack note

This branch stacks on polish/analyze-header-logo, which itself includes the /analyze embed-aspect work. No header/logo, fixture, streaming, validation, feed, tab, meter, or contract behavior was changed.

@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
capcheck Ready Ready Preview, Comment Jul 12, 2026 1:15am

# Conflicts:
#	src/components/capcheck-app.test.tsx
#	src/components/scorecard.tsx
@polter-dev
polter-dev marked this pull request as ready for review July 12, 2026 01:16
@polter-dev
polter-dev merged commit 424a865 into main Jul 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant