Skip to content

Examiner UI - Fixed 12:01 not being shown in NOC Expiry (not PST)#664

Merged
shaangill025 merged 1 commit intomainfrom
fix_26841_fix
Apr 8, 2025
Merged

Examiner UI - Fixed 12:01 not being shown in NOC Expiry (not PST)#664
shaangill025 merged 1 commit intomainfrom
fix_26841_fix

Conversation

@shaangill025
Copy link
Copy Markdown
Contributor

Issue:

Description of changes:
(Verified that time being shown is in Pacific even though system time is in EST)
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 4, 2025

@shaangill025 shaangill025 requested a review from dimak1 April 4, 2025 18:10
@shaangill025 shaangill025 self-assigned this Apr 4, 2025
@bcregistry-sre
Copy link
Copy Markdown
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-664-0b93stn2.web.app

Comment thread strr-base-web/app/utils/date.ts
@shaangill025 shaangill025 merged commit a5b1445 into main Apr 8, 2025
24 checks passed
kris-daxiom added a commit that referenced this pull request Apr 8, 2025
* feat: Registration Todos (#668)

* feat: Registration Todos

* Added Expired to the status array

* API - NOC Events & Created Date Update (#663)

* 26983 - events & timestamp type update

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - lint fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - nox_expiry unit test

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - lint fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - cleanup

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - cleanup

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - add UnitTestConfig to noc_expiry job conftest

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - isort fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - run mode fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - run mode fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - check assignee, feedback changes, remove noc_expiry job changes

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - lint fixes

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

---------

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* noc expiry timezone related fix & noc events (#664)

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* Fix scroll in NOC To Do (#667)

* Fix scroll in NOC To Do

* ci-cd (#671)

* indent (#673)

* add quote (#674)

* fix: Adding run script (#675)

---------

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Co-authored-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Co-authored-by: Dima K <dima1086@hotmail.com>
Co-authored-by: Avni Salhotra <132402145+avni-work@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants