feat: Registration Todos#668
Merged
kris-daxiom merged 2 commits intobcgov:mainfrom Apr 8, 2025
Merged
Conversation
dimak1
reviewed
Apr 8, 2025
Collaborator
dimak1
left a comment
dimak1
left a comment
There was a problem hiding this comment.
Added my comments. Also I created a feature branch for renewals feature-reg-renewals, just in case if we want to merge to main once it is more stable.
Contributor
Author
This is an independent feature from the API perspective and can go into the main directly |
|
kris-daxiom
added a commit
that referenced
this pull request
Apr 8, 2025
* feat: Registration Todos (#668) * feat: Registration Todos * Added Expired to the status array * API - NOC Events & Created Date Update (#663) * 26983 - events & timestamp type update Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - lint fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - nox_expiry unit test Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - lint fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - cleanup Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - cleanup Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - add UnitTestConfig to noc_expiry job conftest Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - isort fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - run mode fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - run mode fix Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - check assignee, feedback changes, remove noc_expiry job changes Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * 26983 - lint fixes Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> --------- Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * noc expiry timezone related fix & noc events (#664) Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> * Fix scroll in NOC To Do (#667) * Fix scroll in NOC To Do * ci-cd (#671) * indent (#673) * add quote (#674) * fix: Adding run script (#675) --------- Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com> Co-authored-by: Shaanjot Gill <shaangill025@users.noreply.github.com> Co-authored-by: Dima K <dima1086@hotmail.com> Co-authored-by: Avni Salhotra <132402145+avni-work@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License