Skip to content

ci-cd#671

Merged
avni-work merged 1 commit intobcgov:mainfrom
avni-work:ci-cd-for-provisional-approval-job
Apr 8, 2025
Merged

ci-cd#671
avni-work merged 1 commit intobcgov:mainfrom
avni-work:ci-cd-for-provisional-approval-job

Conversation

@avni-work
Copy link
Copy Markdown
Contributor

Issue:

  • bcgov/entity/issues/

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@avni-work avni-work requested a review from kris-daxiom April 8, 2025 17:51
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

@kris-daxiom kris-daxiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avni-work avni-work merged commit de9722d into bcgov:main Apr 8, 2025
9 of 10 checks passed
kris-daxiom added a commit that referenced this pull request Apr 8, 2025
* feat: Registration Todos (#668)

* feat: Registration Todos

* Added Expired to the status array

* API - NOC Events & Created Date Update (#663)

* 26983 - events & timestamp type update

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - lint fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - nox_expiry unit test

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - lint fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - cleanup

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - cleanup

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - add UnitTestConfig to noc_expiry job conftest

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - isort fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - run mode fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - run mode fix

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - check assignee, feedback changes, remove noc_expiry job changes

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* 26983 - lint fixes

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

---------

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* noc expiry timezone related fix & noc events (#664)

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>

* Fix scroll in NOC To Do (#667)

* Fix scroll in NOC To Do

* ci-cd (#671)

* indent (#673)

* add quote (#674)

* fix: Adding run script (#675)

---------

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Co-authored-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Co-authored-by: Dima K <dima1086@hotmail.com>
Co-authored-by: Avni Salhotra <132402145+avni-work@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants