REFACTOR: make multiband likelihood call Interferometer.get_detector_response#846
Closed
ColmTalbot wants to merge 42 commits intobilby-dev:simplify-multiband-responsefrom
Closed
Conversation
* TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact
* TST: update CI python versions * TST: bump python version * TST: bump python version * TST: disable windows test
* CI: rename test workflow * CI: limit CI concurrency
…ing saved Joint priors
* MAINT: remove GitLab CI file * MAINT: change URL * MAINT: update URLs * MAINT: update more urls * MAINT: more URLs * MAINT: change URL * MAINT: remove /-/ * MAINT: remove /-/ * MAINT: add missing slash * DOC: update URLs * MAINT: fix pipeline status * DOC: update contributing * DOC: add confidential issue instructions * DOC: tmp fix for milestone * MAINT: update doc links * MAINT: change branch to main * Update README.rst Co-authored-by: Colm Talbot <talbotcolm@gmail.com> * Update README.rst Co-authored-by: Colm Talbot <talbotcolm@gmail.com> * Update README.rst Co-authored-by: Colm Talbot <talbotcolm@gmail.com> * MAINT: change URLs * MAINT: change URL * DOC: update contributing * DOC: change specific to confidential * DOC: change gitlab references to github * MAINT: update URLs for change from master to main * MAINT: change merge request to pull request * MAINT: capitalize Pull requests * DOC: change pull main to fetch * DOC: add note about migration to the changelog * DOC: point to PR that updated the changelog --------- Co-authored-by: Colm Talbot <talbotcolm@gmail.com>
* BLD: build docker images * BLD: fix path to dockerfile * BLD: test container paths * BLD: actually checkout the repository * BLD: fix push conditions * BLD: fix file paths * BLD: skip attestation * BLD: correct tag of docker images * BLD: try updating image tag * BLD: push docker images * BLD: switch to ghcr and don't build containers in PRs * CI: let pages job read registry * DOC: add fixme
* DOC: update note on normalization constants when using prior constraints * DOC: reword sentence
* MAINT: add sampler deprecation warning for pypolychord * MAINT: add sampler deprecation warning for nessai * DOC: change important to warning * DOC: add samplers to sampler plugin library * DOC: add docs about migrating to sampler plugins
* BUG: fix typo in ln_i0 * TST: Add GitHub action testing (bilby-dev#24) * TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact * DEP: Update documentation and examples to reflect changes to random seed * DEP,DOC: Updated doc string to ask for np generator instance instead of legacy generator * [DEP][DOC]: updates from review, typo fix, removal of unnecessary `rng` import * [?]: Removed metadata from jupyter notebooks * Pre-commit fixes * pre-commit re-run I realised that pre-commit didn't check any files because there were no logged chagnes. So I ran pre-commit on everything using "pre-commit run --all-files". This only brought up relevant changes from myself, with the exceptions of: "bilby/bilby_mcmc/sampler.py:525:38: E226 missing whitespace around arithmetic operator" which is outside the remit of this merge request. * Adding Sean to the authors for the CI * Update bilby/core/sampler/dynesty_utils.py Co-authored-by: Colm Talbot <talbotcolm@gmail.com> * Update bilby/core/sampler/dynesty_utils.py Co-authored-by: Colm Talbot <talbotcolm@gmail.com> --------- Co-authored-by: Colm Talbot <talbotcolm@gmail.com> Co-authored-by: Colm Talbot <colm.talbot@ligo.org> Co-authored-by: Sean Hibbit <sean.hibbitt.2019@live.rhul.ac.uk> Co-authored-by: Sean Hibbitt <112953650+bretsnev@users.noreply.github.com>
* BUG: raise RuntimeError if arviz is not installed * TST: add test for to_arviz when arviz is not installed * MAINT: change RuntimeError to ResultError * TST: update test to use ResultError
…e` (bilby-dev#838) * DOC: fix misleading documentation for See bilby-dev#833: the method of was incorrect. This commit also adds some more information to the method of the object. * DOC: autolink mention in detectors.py Co-authored-by: Colm Talbot <talbotcolm@gmail.com> --------- Co-authored-by: Colm Talbot <talbotcolm@gmail.com>
…-dev#47) * FEAT: add argument to specify calibration correction direction * FEAT: add calibration correction specification to the calibration draws file * FORMAT: flake fix in calibration * BUG: fix calibration table read/write * DOC: Improve documentation for calibration correction types * DOC: add module-level docstring describing calibration conventions * TYPO: refactoring typo fixes * TYPO: typo fix in documentation * TEST: update argument name in test * DOC: fix versionadded * DOC: fix version changed
…b. (bilby-dev#837) Co-authored-by: Alexandre Goettel <gottela@cardiff.ac.uk>
* BUG: ensure infinite ACT estimates are properly handled * REFACTOR: promote debug to warning for poor sampling * FMT: remove excess empty line * FMT: remove excess whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://git.ligo.org/lscsoft/bilby/-/merge_requests/1379
I think this has a conflict with #842.
Based on ongoing discussion about implementing different detector responses, it would be nice for the likelihoods to all access the response functions uniformly. The MB likelihood currently has an almost verbatim copy of the Inteferometer.get_detector_response method. This MR provides a minimal change to be able to directly call that method.