201910 simple fixes#855
Closed
sipa wants to merge 90 commits intobitcoin:masterfrom
Closed
Conversation
Includes squashed contributions by GitHub users jonasnick, real-or-random, AustinWilliams, JustinTArthur, ysangkok, RCassatta, Sjors, tnakagawa, and guggero.
…of 'message hash'
Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash'
Though perhaps, the emphasis is warranted given its importance. :-)
remove duplicate warning
If we look at
def IsPayToTaproot(script):
return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1
First byte is is checked for OP_1. OP_1 is 0x51
But the example code in this BIP returns
`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`
First byte 0x01, but it should be 0x51
taproot_output_script: first returned byte should be OP_1 (0x51)
Clarify description of diagram
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
Completely switch to 32-byte public keys in bip-schnorr/taproot/tapscript
Clarify how to disable key path spending
Reword 'quadratic residue of...'
Clarify pseudocode of lift_x
Use key path spend terminology more consistently in taproot/tapscript
Rework resource limits section
Move/reword tagged hashes motivation
minor wording fixes
Remove 0xc1
…chnorr code to match the spec.
…aproot wallet section
…aproot_tweak_seckey too
Improve readability of bip-taproot wallet section
Link to Schnorr's paper instead of Wikipedia
Accept seckey in the form of bytes and not int in the reference BIP-schnorr code...
Extend codeseparator_position and input_index from 16 to 32 bits
Increase max Merkle path length
Small fix: 0xc1 is possible as first control block byte
Member
Author
|
Grr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.