When issuing bitcoind the `stop` rpc command, it waits forever for existing clients to disconnect

[ryancdotorg]

Also, oddly, it continues serving RPC commands to them.

I found this using bitcoinrpc.authproxy in python. Open up a process that polls bitcoind in a loop from python, then issue a stop command from a different client. bitcoind does not stop until the python script is closed.

[sipa]

I believe this is no longer the case since at least #5677 or earlier.

[dcousens]

Could not reproduce with master.

while true; do ./src/bitcoin-cli getinfo && sleep 0.1; done

./src/bitcoin-cli stop

No delay. Synced node.
Loop dumped out the following immediately after the server stopped (as expected).

(make sure server is running and you are connecting to the correct RPC port)
error: couldn't connect to server: unknown (code -1)